-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hardware revB & SDK v2.0.1 #42
Conversation
There's missed new list icon for Crank.toml. I'll add it. |
I need feedback to merge it. |
I gave this a test, using all combinations just out of curiosity.
I can't actually review the code changes in this PR; I'm hoping someone else understands them to give a proper review. |
Hey, maintainer of https://github.com/adamsoutar/playboy here 👋 This patch hasn't quite worked for me (but thanks for working on it!). It builds+runs successfully on Simulator, but when building with
|
Hi. Thanks for working on this patch. I tested this on Windows 11. Works on simulator 2.0, but I get an e0 crash on device 2.0 similar to @tjkirch above when I try to run something as simple as the hello_world.rs from the crankstart repo. I'll try some other things and report back, but let me know if there's any information that can help you here. Same e0 error was reported here, suggesting a fix coming soon, but I have no idea if it has anything to do with what we're seeing here. I tried the hard-coded ARM compiler v9-2019-q4-major and v10 2021.10, I think. Same issue. Edit: building on a Mac, which uses the same v9-2019-q4-major compiler from the SDK (installed to /usr/local/playdate) resulted in the same issue. On Windows, compiler v12.2.mpacbti-rel1 (the latest right now) also resulted in the same issue. I checked and this version compiles the Hello World C example from the SDK (on PlaydateSDK/C_API/Examples/Hello World) with no issues. |
Test Requirements
Place the patched pdc to replace the existing one in the SDK. The patched pdc must be at
It will be hidden, thanks for remind 👍
Please read Test Requirements few lines above. PDC in SDK 2.0 have issues with sections and reloc-table. Try to use patched pdc. @adamsoutar, @CarlosMendonca What version of pdc did you use? Sorry for inconvenience and missed instructions for testing. Thanks to all so much for feedback! ❤️🔥 It absolutely necessary. This PR still need tests and feedback, as well as pathed pdc will released in the SDK. |
Also, a little bit of good secret news
|
I tested your change with SDK 2.0.1, which has the pdc segment fix, and it does now launch on device. |
Well, SDK2.0.1 just released with fixed pdc as I hope.
|
Confirmed it works with the patched pdc.exe (2.0.0-dev.156439) on Windows 11 with the latest ARM compiler ("12.2.MPACBTI-Rel1 (Build arm-12-mpacbti.34)) 12.2.1 20230214"). Thanks, @boozook! It should work with SDK 2.0.1 binaries that were released today. For Windows users, SDK 2.0.1 is not yet available on Winget, but people can install it manually. I'll probably submit a PR to the Winget package repo later. |
Look at how implemented "latest" in the get-playdate-sdk action. |
So, I'll update CI here and then will merge this pr. |
_oops previously was wrong place_
Cross Reference Table spam fixed. |
@adamsoutar, is that problem steel exist? |
related issue: crankstart #45
Note: This is MVP, highly need testing and reviewing. 🙄