Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed need for -Z build-std #37

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Removed need for -Z build-std #37

merged 1 commit into from
Mar 15, 2023

Conversation

catt-io
Copy link
Contributor

@catt-io catt-io commented Mar 14, 2023

Fixes the error discussed at pd-rs/crankstart#30 by removing the need to build std from source. That does appear to be a bug caused from a regression in rust nightly, but this may still be a better option to lower the reliance on nightly rust.

Nightly is still necessary for the aloc feature, update readme to accommodate.

@lilyinstarlight
Copy link
Contributor

Is it possible to make this configurable?

@rtsuk
Copy link
Collaborator

rtsuk commented Mar 15, 2023

What is the benefit of making this configurable?

@lilyinstarlight
Copy link
Contributor

What is the benefit of making this configurable?

I don't use rustup and build-std works fine for me (and propagating an appropriate rust-std build without rustup may be annoying). But if allowing build-std (or even just making cargo flags in general configurable via environment variable, e.g. CRANK_CARGO_FLAGS) is prohibitively difficult, I can probably figure out how to propagate a thumbv7em-none-eabihf build of rust-std separately

So if it's too difficult, it doesn't have to hold this up

@rtsuk
Copy link
Collaborator

rtsuk commented Mar 15, 2023

Makes sense. If you want to add in a flag for it, I'll merge it.

@rtsuk rtsuk merged commit 7bea34b into pd-rs:main Mar 15, 2023
@boozook
Copy link
Member

boozook commented Jun 27, 2023

-Z build-std needed to build alloc and use heaped c-strings (CString) properly. Strings is just as example. We're need to build alloc crate for this target.

@boozook
Copy link
Member

boozook commented Jun 27, 2023

I've return build-std just now in the #42, but in nearest future I'll try to get it configurable as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants