Networking Refactor - PR Series #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssAPI.swift` layers (#177) - Add `TrackingEventsAPI.swift` & `CheckoutOrdersAPI.swift` - Remove usage of `APIRequest` protocol in favor of inline `RESTRequest` object creation - Add `HTTPResponse` type - Set the stage for having a GraphQL & REST requests use same same underlying `HTTP` layer
…plementation (#182) - Add `fetch(request: GraphQLRequest)` method to `APIClient` - This class now has only 2 public functions, an equivalent for REST & GraphQL - Unifies REST & GraphQL requests to use the same underlying HTTP, URLRequest, and URLSession implementations - Remove `GraphQLClient` and other no-longer-used GraphQL files - Rename `GraphQLQueryResponse` --> `GraphQLHTTPResponse`
- Add GraphQL response parsing ability to `HTTPResponseParser`
- Move Post body encoding from `APIClient`
- Require `Encodable` type in `RESTRequest` & `GraphQLRequest`s instead of `Data`
- Add `VaultPaymentTokensAPI` layer
- Tests
- Remove `GraphQLClient_Tests` now that `GraphQLClient` is gone
- Update `HTTPResponseParser_Tests`
- Remove `APIRequest` protocol
- Update `TrackingEventsAPI` for mock `APIClient` injection
- Update mocks
- `MockTrackingEventsAPI` (added), `MockAPIClient` (updated), `MockHTTP` (updated)
- Use `captured` terminology on mocks
- Fix unit tests `HTTP_Tests`, `APIClient_Tests`, `AnalyticsService_Tests` & add `TrackingEventsAPI_Tests`
- Add tests for:
- `CheckoutOrdersAPI`
- `VaultPaymentsTokenAPI`
- Update tests for: `CardClient` & `ConfirmPaymentSourceRequest`
- Move mocks into `CardPaymentTests/Mocks` dir
- Add mocks for:
- `CheckoutOrdersAPI` and `VaultPaymentTokensAPI` for use in `CardClient_Tests`
- Repurpose `CardResponses` file of sample JSON responses to be raw `ConfirmPaymentSourceReponse` types
scannillo
force-pushed
the
networking-refactor
branch
from
79c8e82 to
9c2fc60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for changes
These changes have already been reviewed in this series of PRs. I created this PR solely to confirm CI passes.
Summary
These PRs re-architect our networking layer to allow for re-use between GraphQL and REST request implementation. We can now use the same underlying HTTP layer for each request, in addition to a single implementation of Apple's URLSession, URLRequest, JSONDecoder, & JSONEncoder.
This reduces duplication, and increases testability of each layer through removing heavy logic that previously lived in protocol extensions. This also unifies our APIs for making a REST & GraphQL request from the feature client level.
Next Steps
We need to create JIRAs for the following tasks:
SourcesChecklist
Added a changelog entryAuthors
@scannillo