[Part 5] Networking Refactor - CardPayment unit tests #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* vault without purchase * clean up cardClient initializer * Use associatedType for variables for GraphQLQuery protocol * moving setuptoken call to demo app * use APIRequest for merchantServer setupToken request * use enum for PaymentSourceInput for different payment options * get request for setup token details * move graphQL request, responses from Core to Card module * remove APIRequest use in demo app * Add VaultCardDelegate for VaultCardResult * Add payment token creation in demo app * remove duplicate UpdateSetupTokenQuery.swift * rename UpdateSetupTokenRequest to UpdateSetupTokenQuery * added newly named file reference to project * add mocks for unit tests, pr feedback * disable swiftlint for multiline query, target for card test * correct target for MockGraphQLClient * CardClient vault error tests * docStrings and CHANGELOG * PR feedback * PR feedback * PR feedback nodoc String for GraphQLQuery requestBody() * spacing in paymentTokenRequest * PR feedback * PR feedback from Jax 8/16/23 * PR feedback from Jax cleanup
…r data in GraphQL request types to prevent double encoding
Signed-off-by: Victoria Park <[email protected]>
scannillo
changed the title
scannillo
changed the title
scannillo
changed the title
KunJeongPark
approved these changes
Aug 30, 2023
sshropshire
approved these changes
Aug 31, 2023
Base automatically changed from
networking-refactor-tests-rebased
to
networking-refactor
September 5, 2023 15:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for changes
This PR re-writes our
CardPaymentsTestsbased on the source code changes introduced in this series of networking layer refactor PRs.Summary of changes
CheckoutOrdersAPIVaultPaymentsTokenAPICardClient(now relies on mocked<PPassAPI>classes to stub network responses)ConfirmPaymentSourceRequest(now it's only a model type, versus before it had many functions)CardPaymentTests/MocksdirCheckoutOrdersAPIandVaultPaymentTokensAPIfor use inCardClient_TestsCardResponsesfile of sample JSON responses to be rawConfirmPaymentSourceReponsetypesNext
mainnow! Tests are passing 😎main:APIClient-->NetworkingClientChecklist
Added a changelog entryAuthors
@scannillo