Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded APIRequest conformance from Demo #178

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Remove unneeded APIRequest conformance from Demo #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Demo/Demo/Models/ClientIDRequest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation
import CorePayments

struct ClientIDRequest: APIRequest {
struct ClientIDRequest {

Copy link
Collaborator

@KunJeongPark KunJeongPark Aug 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sammy, on my draft PR for vault without purchase, (

paypal-ios/Demo/Demo/Networking/DemoMerchantAPI.swift

Line 185 in de43d87

private func createUrlRequest(
) I had reused this createUrlRequest for setup token call with APIRequest protocol. I have to have some other protocol so we can take in different request structs to create urlRequest for demo app.

What I can do right now is just create a separate createUrlRequest functions for both REST calls

Copy link
Collaborator

@KunJeongPark KunJeongPark Aug 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed it in latest commit in the PR. It's redundant but I will consolidate if we have another protocol.

Copy link
Collaborator Author

@scannillo scannillo Aug 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Demo should never have been using APIRequest. Awesome, I'll check out your new updates!

typealias ResponseType = ClientIDResponse

Expand Down