Remove unneeded APIRequest conformance from Demo #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxdesmarais
approved these changes
Aug 9, 2023
KunJeongPark
reviewed
Aug 9, 2023
| @@ -1,7 +1,7 @@ | |||
| import Foundation | |||
| import CorePayments | |||
|
|
|||
| struct ClientIDRequest: APIRequest { | |||
| struct ClientIDRequest { | |||
|
|
|||
There was a problem hiding this comment.
Sammy, on my draft PR for vault without purchase, (
) I had reused this createUrlRequest for setup token call with APIRequest protocol. I have to have some other protocol so we can take in different request structs to create urlRequest for demo app.What I can do right now is just create a separate createUrlRequest functions for both REST calls
There was a problem hiding this comment.
I addressed it in latest commit in the PR. It's redundant but I will consolidate if we have another protocol.
There was a problem hiding this comment.
The Demo should never have been using APIRequest. Awesome, I'll check out your new updates!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for changes
Make it clear that the Demo does not rely on the SDK's internal
APIRequestprotocol.We're also planning to remove this protocol entirely (👀 #177)
Summary of changes
APIRequestonClientIDRequestin demo appChecklist
Added a changelog entryAuthors
@scannillo