Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven Class FireCommand Method Pass Environment Variables #228

Closed
wants to merge 11 commits into from

Conversation

jameshearttech
Copy link

This pull request started from the need to have environment variables from the system/shell in the child process spawned by the maven class firecommand method. I made a handful of other commits to get the project to compile. I couldn't get the npm test script to run, but that's because I'm developing in a dev container without x server. I packaged the extension, installed it locally, and confirmed the environment variables are available to the child processes as expected.

Reference Bug Report: VS Code Payara Tools Extension - Payara Micro Instance - Missing Environment Variables #91

@reunionofrock
Copy link

Hello I have this issue Error on executing startMicro task:spawn EINVAL

@jameshearttech
Copy link
Author

@reunionofrock can you provide more details on what you did specifically to get this error? I have a version of the extension packaged from my fork, which is working for me, but I'm not sure if that is what you are using, too.

@jGauravGupta
Copy link
Contributor

Thank you very much for your valuable contribution! I’m pleased to inform you that the issue has been addressed through the following PRs:

#229
#231

As these changes resolve the problem, we can proceed with closing this PR. Your efforts are truly appreciated, and we look forward to any future contributions you may have to Payara. Once again, thank you for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants