Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: VS Code Payara Tools Extension - Payara Micro Instance - Missing Environment Variables/FISH-9450 #91

Closed
jameshearttech opened this issue Jul 31, 2024 · 2 comments
Assignees
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect

Comments

@jameshearttech
Copy link

jameshearttech commented Jul 31, 2024

Brief Summary

When deploying to a Payara Micro instance using the VS Code Payara Tools extension the system and shell environment variables are missing.

Expected Outcome

The system and shell environment variables should exist for the Payara Micro instance (e.g., System.getenv()).

Current Outcome

System.getenv() return null rather than the value of the environment variables.

Reproducer

Deploy anything using the VS Code Payara Tools extension to a Payara Micro instance. Compare environment variables (e.g., printenv to /proc/<pid>/environ) of the system to the process started by the extension when deploying.

Operating System

Windows 11 (host), Podman 5.1.2, Debian 12 (dev container)

JDK Version

OpenJDK Runtime Environment (build 17.0.11+9-Debian-1deb12u1)

Ecosystem Tool

Visual Studio IDE Plugin

@jameshearttech jameshearttech added Status: Open Issue has been triaged by the front-line engineers and is being worked on verification Type: Bug Label issue as a bug defect labels Jul 31, 2024
@jameshearttech
Copy link
Author

jameshearttech commented Jul 31, 2024

@Elifzeynepedman looks like the Maven class fireCommand calls child_process.spawn, but it does not pass environment variables to the child process.

https://github.com/payara/ecosystem-vscode-plugin/blob/1.3.0/src/main/fish/payara/project/Maven.ts#L134-L140

@felixif
Copy link

felixif commented Aug 14, 2024

Hello @jameshearttech,

I was able to reproduce the issue and raised an internal issue, FISH-9450, to address it. Thank you for your report!

@felixif felixif changed the title Bug Report: VS Code Payara Tools Extension - Payara Micro Instance - Missing Environment Variables Bug Report: VS Code Payara Tools Extension - Payara Micro Instance - Missing Environment Variables/FISH-9450 Aug 14, 2024
@felixif felixif added Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev and removed Status: Open Issue has been triaged by the front-line engineers and is being worked on verification labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect
Projects
None yet
Development

No branches or pull requests

3 participants