Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect check concealing failures with OpenSSL #875

Merged
merged 1 commit into from
May 4, 2023
Merged

Fix incorrect check concealing failures with OpenSSL #875

merged 1 commit into from
May 4, 2023

Conversation

paullouisageneau
Copy link
Owner

This PR fixes openssl::check() by removing the incorrect BIO_EOF check which was concealing failure conditions. The empty input BIO situation is handled by the err == SSL_ERROR_WANT_READ check.

Fix #869

@paullouisageneau paullouisageneau linked an issue May 4, 2023 that may be closed by this pull request
WebSocket stuck in Connecting state when garbage is received #865
Closed
@paullouisageneau paullouisageneau removed a link to an issue May 4, 2023
WebSocket stuck in Connecting state when garbage is received #865
Closed
@paullouisageneau paullouisageneau linked an issue May 4, 2023 that may be closed by this pull request
WebSocket stuck in Connecting state (TLS/OpenSSL) #869
Closed
@paullouisageneau paullouisageneau merged commit c39e9f8 into v0.18 May 4, 2023
@paullouisageneau paullouisageneau deleted the fix-eof-check-openssl branch May 4, 2023 12:02
@paullouisageneau paullouisageneau mentioned this pull request May 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebSocket stuck in Connecting state (TLS/OpenSSL)
1 participant
@paullouisageneau