Merge pull request #875 from paullouisageneau/fix-eof-check-openssl

Fix incorrect check concealing failures with OpenSSL
paullouisageneau · May 4, 2023 · c39e9f8 · c39e9f8
2 parents 10eed72 + a793023
commit c39e9f8
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/src/impl/tls.cpp b/src/impl/tls.cpp
@@ -102,15 +102,12 @@ bool check(int success, const string &message) {
 }
 
 bool check(SSL *ssl, int ret, const string &message) {
-	if (ret == BIO_EOF)
-		return true;
-
 	unsigned long err = SSL_get_error(ssl, ret);
 	if (err == SSL_ERROR_NONE || err == SSL_ERROR_WANT_READ || err == SSL_ERROR_WANT_WRITE) {
 		return true;
 	}
 	if (err == SSL_ERROR_ZERO_RETURN) {
-		PLOG_DEBUG << "DTLS connection cleanly closed";
+		PLOG_DEBUG << "OpenSSL connection cleanly closed";
 		return false;
 	}
 	string str = error_string(err);