This repository has been archived by the owner on Apr 11, 2018. It is now read-only.
Make it ie8 compatible (sort of). #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -255,6 +255,9 @@ function reader(str) { | |||
|
|
|||
| utils.some(rules, function (rule) { | |||
| return utils.some(rule.regex, function (regex) { | |||
| if(!regex){ | |||
There was a problem hiding this comment.
utils.some will not execute the function if rule.regex does not exist or is an empty array.
There was a problem hiding this comment.
As I mentioned above when rule.regex is [a,b,c,undefined] then the last regex will probably be undefined (depend on the return value of the regex before it). Both remove the trailing comma or add this check will prevent the issue. If I remove this check we should make sure there are no trailing comma at any where https://github.com/NStal/swig/blob/master/lib/lexer.js#L76 in future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In modern js engine a array like [1,2,3,] will be intepreted as [1,2,3]
But under IE8 it turns to [1,2,3,undefined]
I fix some little issue related with it. After this fix it's able to run under IE8 with some(many) other pollyfill. But those pollyfills can be done out side the swig.