fix(types): Work around to fix issue with consumers recieving a type error. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, not necessary, but to take it a step further you could also change as @wise-king-sullyman pointed out in slack:
|
jschuler
approved these changes
Apr 16, 2024
| @@ -3,7 +3,7 @@ import Point from './geom/Point'; | |||
| import Dimensions from './geom/Dimensions'; | |||
| import Rect from './geom/Rect'; | |||
| import { Padding, Translatable } from './geom/types'; | |||
| import { LayoutOptions } from './layouts'; | |||
| import { LayoutOptions } from './layouts/LayoutOptions'; | |||
There was a problem hiding this comment.
Yes, types should never include a full directory only the direct dependents.
jeff-phillips-18
approved these changes
Apr 17, 2024
|
🎉 This PR is included in version 5.3.0-prerelease.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #165
Description
Fixes issue where consumers are receiving a type error when using an older version for react-types.