Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with 5.3.0-prerelease.5 running Patternfly release candidate 5.3 #165

Closed
dlabaj opened this issue Apr 3, 2024 · 3 comments · Fixed by #174
Closed

Error with 5.3.0-prerelease.5 running Patternfly release candidate 5.3 #165

dlabaj opened this issue Apr 3, 2024 · 3 comments · Fixed by #174
Assignees
Labels
bug Something isn't working released on @prerelease

Comments

@dlabaj
Copy link
Contributor

dlabaj commented Apr 3, 2024

Describe the problem
Openshift is seeing the following error when running verison @patternfly/react-topology": "5.3.0-prerelease.5 of react topology.

`
ERROR in node_modules/@patternfly/react-topology/src/components/layers/Layer.tsx:76:24
TS2322: Type '{ children: ReactNode; ref: MutableRefObject; }' is not assignable to type 'IntrinsicAttributes & RefAttributes'.
Property 'children' does not exist on type 'IntrinsicAttributes & RefAttributes'.
74 | }, [order, layerNode]);
75 |

76 | return createPortal({children}, layerNode);
| ^^^^^^^^^^^^^^
77 | });
78 |
79 | const Layer: React.FunctionComponent = ({ id, children, orderKey }) =>

ERROR in node_modules/@patternfly/react-topology/src/components/layers/LayerContainer.tsx:11:29
TS2694: Namespace 'React' has no exported member 'ForwardRefRenderFunction'.
9 | }
10 |

11 | const LayerContainer: React.ForwardRefRenderFunction<SVGGElement, LayerContainerProps> = ({ children }, ref) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^
12 | // accumulate parent positions
13 | const element = React.useContext(ElementContext);
14 | let p = element;

ERROR in node_modules/@patternfly/react-topology/src/components/popper/Popper.tsx:199:51
TS2724: 'React' has no exported member named 'RefCallback'. Did you mean 'useCallback'?
197 | ]);
198 |

199 | const nodeRefCallback = React.useCallback<React.RefCallback>(
| ^^^^^^^^^^^
200 | node => {
201 | nodeRef.current = node;
202 | initialize();

ERROR in node_modules/@patternfly/react-topology/src/layouts/BreadthFirstLayout.ts:13:11
TS6133: 'gridOptions' is declared but its value is never read.
11 |
12 | export class BreadthFirstLayout extends BaseLayout implements Layout {

13 | private gridOptions: BreadthFirstLayoutOptions;
| ^^^^^^^^^^^
14 |
15 | constructor(graph: Graph, options?: Partial) {
16 | super(graph, options);

ERROR in node_modules/@patternfly/react-topology/src/layouts/GridLayout.ts:13:11
TS6133: 'gridOptions' is declared but its value is never read.
11 |
12 | export class GridLayout extends BaseLayout implements Layout {

13 | private gridOptions: GridLayoutOptions;
| ^^^^^^^^^^^
14 |
15 | constructor(graph: Graph, options?: Partial) {`

** Additional Information **

The following are the release candidate versions:

"@patternfly/patternfly": "5.3.0-prerelease.5",
"@patternfly/react-charts": "7.3.0-prerelease.6",
"@patternfly/react-code-editor": "5.3.0-prerelease.25",
"@patternfly/react-core": "5.3.0-prerelease.23",
"@patternfly/react-drag-drop": "5.3.0-prerelease.23",
"@patternfly/react-icons": "5.3.0-prerelease.3",
"@patternfly/react-styles": "5.3.0-prerelease.3",
"@patternfly/react-table": "5.3.0-prerelease.25",
"@patternfly/react-templates": "1.0.0-prerelease.6",
"@patternfly/react-tokens": "5.3.0-prerelease.3",
"@patternfly/react-topology": "5.3.0-prerelease.5",
"@patternfly/quickstarts": "5.3.0-prerelease.1"

What is your product and what release date are you targeting?
This is for release of 5.3.0 of PatternFly.

@dlabaj dlabaj added the bug Something isn't working label Apr 3, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Apr 3, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Extensions Apr 3, 2024
@jeff-phillips-18
Copy link
Member

@dlabaj Did any project settings changed? Some of these things have been around forever.

@jeff-phillips-18
Copy link
Member

@dlabaj Was this fixed by #168 ?

Copy link

🎉 This issue has been resolved in version 5.3.0-prerelease.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released on @prerelease
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants