fix(DatePicker): error not showing on date reset by button #9267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-9267.surge.sh A11y report: https://patternfly-react-pr-9267-a11y.surge.sh |
thatblindgeye
approved these changes
Jun 16, 2023
tlabaj
requested changes
Aug 15, 2023
| @@ -40,8 +40,12 @@ export interface DatePickerProps | |||
| inputProps?: TextInputProps; | |||
| /** Flag indicating the date picker is disabled. */ | |||
| isDisabled?: boolean; | |||
| /** Flag indicating the date picker is required. */ | |||
| isRequired?: boolean; | |||
There was a problem hiding this comment.
Could you rebase. Another PR went in to fix a different issue and it added an API for isRequred and emptyDateText
… error when cleared and required
adamviktora
force-pushed
the
datePickerClearOnReset
branch
from
711e828
to
0a971ab
Compare
kmcfaul
approved these changes
Aug 23, 2023
tlabaj
reviewed
Aug 23, 2023
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
…y#9267) * fix(DatePicker): clear error on date reset * feat(DatePicker): add clear date example to controlled DatePicker * test(DatePicker): add integration test for clear date * feat(DatePicker): update clear date logic based on patternfly#9373 * fix(DatePicker): hide error when date cleared and not required + show error when cleared and required * refactor(DatePicker) * fix(DatePicker): prop removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8905