Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - DatePicker - Error stays when resetting the date #8905

Closed
kmalyjur opened this issue Apr 3, 2023 · 2 comments · Fixed by #9267
Closed

Bug - DatePicker - Error stays when resetting the date #8905

kmalyjur opened this issue Apr 3, 2023 · 2 comments · Fixed by #9267
Assignees
Labels
Milestone

Comments

@kmalyjur
Copy link

kmalyjur commented Apr 3, 2023

The error does not disappear when resetting the invalid value of the DatePicker to a blank one by not manually deleting it.

Steps to reproduce:
https://codesandbox.io/s/determined-banzai-h2876p?file=/index.tsx

  1. Write some invalid date into the text input of the DateTime component (e.g. "a")
  2. Click the "Clear date" button
    => The error message and the error icon do not disappear as they should

I am using @patternfly/[email protected].

@nicolethoen nicolethoen transferred this issue from patternfly/patternfly Apr 3, 2023
@nicolethoen
Copy link
Contributor

Problem is within dateParse. If you override it making empty string a valid date, you should be good to go.

Image

@mcarrano mcarrano added this to the Post v5 priority milestone Apr 4, 2023
@nicolethoen nicolethoen reopened this Apr 4, 2023
@stale
Copy link

stale bot commented Jun 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants