feat(react-core/bullseye): added Bullseye Layout #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for patternfly-react ready! Built with commit 14d0039 |
package.json
Outdated
| "storybook:run": "start-storybook -c storybook -p 6006", | ||
| "storybook:build": "build-storybook -c storybook -o .out", | ||
| "storybook:run": "yarn build && start-storybook -c storybook -p 6006", | ||
| "storybook:build": "yarn build && build-storybook -c storybook -o .out", |
There was a problem hiding this comment.
Is this intended as part of this PR?
There was a problem hiding this comment.
I can separate it out if needed, but yes. Seems people are still having issues with running storybook and not building first.
dmiller9911
force-pushed
the
react-core/bullseye
branch
from
14d0039 to
c5d8e0a
Compare
Pull Request Test Coverage Report for Build 1656
💛 - Coveralls |
|
can you add some snapshots? I was looking for the rendered markup... |
affects: @patternfly/react-core, @patternfly/react-docs Added Bullseye layout from here: https://pf-next.com/layouts/Bullseye/examples/ ISSUES CLOSED: patternfly#434
dmiller9911
force-pushed
the
react-core/bullseye
branch
from
c5d8e0a to
0135f46
Compare
jeff-phillips-18
approved these changes
Jul 2, 2018
priley86
approved these changes
Jul 2, 2018
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: @patternfly/react-core, @patternfly/react-docs
Added Bullseye layout from here: https://pf-next.com/layouts/Bullseye/examples/
ISSUES CLOSED: #434