Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Target Topology View #678

Closed
9 tasks done
tthvo opened this issue Nov 18, 2022 · 3 comments · Fixed by #891
Closed
9 tasks done

[Story] Target Topology View #678

tthvo opened this issue Nov 18, 2022 · 3 comments · Fixed by #891
Assignees

Comments

@tthvo
Copy link
Member

tthvo commented Nov 18, 2022

Related to patternfly/patternfly-react#435

We could have a separate side-card tab for target view (Topology) as here but with some tweaks? Other pages can just use context selector similar to how we select namespace in OpenShift.

topology-sample

This way we can have some initial setup for multi-namespace support as we discussed. Also, filters can be supported here too. I guess this would mean all operations on target list (i.e. add, delete, edit) must be done only on this new side-car tab.

@tthvo tthvo added the feat New feature or request label Nov 18, 2022
@tthvo tthvo self-assigned this Nov 18, 2022
@tthvo tthvo moved this to Todo in 2.3.0 release Nov 18, 2022
@tthvo tthvo changed the title [Task] Target Topology View [Story] Target Topology View Nov 18, 2022
@tthvo
Copy link
Member Author

tthvo commented Nov 21, 2022

For our case, the /api/v2.2/discovery endpoint will return a discovery tree and group the targets within correct REALM (i.e. OpenShift, JDP, Custom and Agent push). This means the front-end would just need to render this tree hierarchically and have a selector to filter REALM. Everything else under REALM node is just rendered as it is.

See an example below for the visualization of the returned tree:

When running on OpenShift:

openshift-discovery

Others (i.e. JDP):

other-discovery

@tthvo
Copy link
Member Author

tthvo commented Nov 22, 2022

We can implement actions on target (i.e. target creation form using Drawer) as this design:

detail-drawer

This way, we can see and edit details directly. The target creation form can be implemented in a drawer like this too.

@andrewazores andrewazores moved this from Todo to In Progress in 2.3.0 release Jan 31, 2023
@tthvo
Copy link
Member Author

tthvo commented Feb 13, 2023

Current issue with TS type checking: patternfly/react-topology#18 after bumping topology package version to 4.91.*.

Current solution: setting "strictFunctionTypes": false, tho strict mode is still enabled with "strict": true for tsconfig.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants