fix(next modal): prevent auto aria-labelledby if aria-label is passed #11088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,6 +58,7 @@ exports[`Disclosure ExpandableSection 1`] = ` | |||
| > | |||
| <button | |||
| aria-controls="content-id" | |||
| aria-expanded="false" | |||
There was a problem hiding this comment.
The updates to these snapshots were needed because the last v5 PR didn't update them and they were failing.
|
Preview: https://patternfly-react-pr-11088.surge.sh A11y report: https://patternfly-react-pr-11088-a11y.surge.sh |
wise-king-sullyman
requested review from
a team,
tlabaj and
kmcfaul
and removed request for
a team
tlabaj
approved these changes
Sep 30, 2024
thatblindgeye
approved these changes
Oct 9, 2024
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11068
Additional issues: