Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Modal - self referrential aria-labelledby causing accessible name issues #11068

Closed
wise-king-sullyman opened this issue Sep 26, 2024 · 1 comment · Fixed by #11088
Closed

Bug - Modal - self referrential aria-labelledby causing accessible name issues #11068

wise-king-sullyman opened this issue Sep 26, 2024 · 1 comment · Fixed by #11088
Assignees
@wise-king-sullyman
Labels
PF Team PF5
Milestone
2024.Q3

Comments

@wise-king-sullyman
Copy link
Contributor

Describe the problem
PF5 version of #11011

The new Modal has an aria-labelledby that points to itself when an aria-label is passed, which causes a11y issues.

Approach can likely be the same as #11012, just placed on v5
@wise-king-sullyman wise-king-sullyman self-assigned this Sep 26, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Sep 26, 2024
@kmcfaul kmcfaul moved this from Needs triage to Not started in PatternFly Issues Sep 26, 2024
@kmcfaul kmcfaul added this to the 2024.Q3 milestone Sep 26, 2024
@wise-king-sullyman wise-king-sullyman mentioned this issue Sep 27, 2024
Merged
@wise-king-sullyman wise-king-sullyman linked a pull request Sep 30, 2024 that will close this issue
fix(next modal): prevent auto aria-labelledby if aria-label is passed #11088
Merged
@tlabaj
Copy link
Contributor

tlabaj commented Oct 9, 2024

close by #11088

@tlabaj tlabaj closed this as completed Oct 9, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
PF Team PF5
Projects
PatternFly Issues
Archived in project
Milestone
2024.Q3
3 participants
@wise-king-sullyman @tlabaj @kmcfaul