Updates button info architecture to align with guidelines. #3061

edonehoo · 2022-07-08T14:21:11Z

Closes #3059

patternfly-build · 2022-07-08T14:28:58Z

PF4 preview: https://patternfly-org-pr-3061-v4.surge.sh/v4

packages/v4/patternfly-docs/content/design-guidelines/components/button/button.md

mmenestr

Overall looks good! Just left a few comments - and also want to add that half the images seem to not show up. Not sure why that's the case - maybe there' not in the folder, or there's a formatting issue but I would just double check all the images in the previews!

You can see the website preview using this link: https://patternfly-org-pr-3061-v4.surge.sh/v4/components/button/design-guidelines

edonehoo · 2022-07-12T20:31:40Z

@mmenestr made those changes! can you let me know how the images look? I was still able to see them even with the preview link you sent, but maybe I'm missing something.

packages/v4/patternfly-docs/content/design-guidelines/components/button/button.md

…nto text-input-group * 'main' of https://github.com/patternfly/patternfly-org: (170 commits) chore(release): releasing packages [ci skip] Updates button info architecture to align with guidelines. (patternfly#3061) Card design guideline changes. (patternfly#3087) chore(release): releasing packages [ci skip] iss3078 (patternfly#3079) chore(release): releasing packages [ci skip] changing alert guidelines (patternfly#3064) chore(release): releasing packages [ci skip] mastshead (patternfly#3062) chore(release): releasing packages [ci skip] jumplink (patternfly#3051) chore(release): releasing packages [ci skip] calendar (patternfly#3058) chore(release): releasing packages [ci skip] feat(doc-framework): add dark theme toggle for full page examples (patternfly#3056) chore(release): releasing packages [ci skip] edit overflow guidelines (patternfly#3038) chore(release): releasing packages [ci skip] docs(a11y): create template for a11y docs (patternfly#3019) docs(Tooltip): add a11y docs (patternfly#2892) ... # Conflicts: # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/attribute-value-filter.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/auto-complete-search.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/text-input-elements.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/text-input-group.md

…y#3061) * Updates button info architecture to align with guidelines. * Updates button design guidelines. * Fixes typo and moves link subsection.

Updates button info architecture to align with guidelines.

8bdbd96

edonehoo requested a review from mmenestr July 8, 2022 14:21

mmenestr reviewed Jul 11, 2022

View reviewed changes