edit overflow guidelines #3038
edit overflow guidelines #3038
Conversation
| * Use an overflow menu in a table toolbar to group a number of actions and create visual space. Avoid having more than 3 actions fully displayed within a toolbar. | ||
|
|
||
|
|
||
| <img src="./img/toolbaroverflow.png" alt="image showing toolbar overflow" width="1765" /> |
There was a problem hiding this comment.
I think this build is failing because you don't need the . at the beginning of the image src url.
There was a problem hiding this comment.
hmm, I've used the same format on other images and it worked fine! I can try that though! Margot mentioned it may have something to do with issues our symbols library has been having and how the black boxes within pagination are causing issues.
There was a problem hiding this comment.
Okay wait I just went back into VSC and all the additional content I added is no longer there. not sure why that happened, hahah but I'm assuming that could be part of the problem. Going back now
| <img src="./img/tableoverflow.png" alt="image showing table with overflow" width="2315" /> | ||
| * Use an overflow menu within a card component to present additional menu options or provide action links. | ||
|
|
||
| <img src="./img/card.png" alt="image showing card overflow" width="370" /> |
There was a problem hiding this comment.
Idk if this could be causing the whole problem but it looks like the actual image file is called "Card.png" with a capital C, but in this img you're calling it with "card.png" lower case C. I'd just adjust that and see if it makes a difference?
|
PF4 preview: https://patternfly-org-pr-3038-v4.surge.sh/v4 |
|
@ssalice9 looks good but the images have the black squares in them, so just need to replace them! Maybe with all the stuff we did it didn't take in the new images? I'm not sure Also would update the "Example" header to "When to use" and follow the regular structure for that- you can keep the images as is but we shouldn't stray from the classic when to use vs when not to use headers IMO |
|
hm... something still feels off - you have two copies of the overflow-menu guidelines in this PR. |
|
Yeah I noticed that as well, I'm not sure why. I made the changes that
Margot suggested and then pushed them to that branch, it's still waiting to
pass the checks so I'm not sure if all the right changes went. But when I
do "git status," it says the branch is up to date.
…On Fri, Jul 8, 2022 at 8:41 AM Nicole Thoen ***@***.***> wrote:
hm... something still feels off - you have two copies of the overflow-menu
guidelines in this PR.
—
Reply to this email directly, view it on GitHub
<#3038 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZG24FHNSW25O7QLWWXISBDVTAOWZANCNFSM52KOKBDQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…nto text-input-group * 'main' of https://github.com/patternfly/patternfly-org: (170 commits) chore(release): releasing packages [ci skip] Updates button info architecture to align with guidelines. (patternfly#3061) Card design guideline changes. (patternfly#3087) chore(release): releasing packages [ci skip] iss3078 (patternfly#3079) chore(release): releasing packages [ci skip] changing alert guidelines (patternfly#3064) chore(release): releasing packages [ci skip] mastshead (patternfly#3062) chore(release): releasing packages [ci skip] jumplink (patternfly#3051) chore(release): releasing packages [ci skip] calendar (patternfly#3058) chore(release): releasing packages [ci skip] feat(doc-framework): add dark theme toggle for full page examples (patternfly#3056) chore(release): releasing packages [ci skip] edit overflow guidelines (patternfly#3038) chore(release): releasing packages [ci skip] docs(a11y): create template for a11y docs (patternfly#3019) docs(Tooltip): add a11y docs (patternfly#2892) ... # Conflicts: # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/attribute-value-filter.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/auto-complete-search.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/img/text-input-elements.png # packages/v4/patternfly-docs/content/design-guidelines/components/text-input-group/text-input-group.md
* edit overflow guidelines * edit overflow guidelines * edit overflow guidelines * overflow typo * overflow edits * overflow
closes #3029