fix(tabs)!: tabscontroller refactor #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let tabscontroller handle the aria stuff only, for the most part. Total separation between RTIC and tabs state. Disabled tabs are still able to be focused via RTIC, just that they can't change the Tab's active tab state. Use context instead of cascade Use shadow classes instead of reflected attrs (but keep the attrs for now to avoid breaking changes)
🦋 Changeset detectedLatest commit: 0d19f99 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
demo
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
zeroedin
reviewed
Mar 4, 2024
|
Should we now say that if Right now the component becomes selectable. |
|
The idea is that users should not set aria attrs on any tab elements. They should only and always use |
zeroedin
reviewed
Mar 4, 2024
zeroedin
reviewed
Mar 4, 2024
zeroedin
reviewed
Mar 4, 2024
zeroedin
approved these changes
Mar 5, 2024
nikkimk
reviewed
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2695
What I did
Total separation between RTIC and tabs state. Disabled tabs are still able to be focused via RTIC, just that they can't change the Tab's active tab state.
Remove most of tabscontroller's logic in favour of context, rtic.
Testing Instructions