-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tabs): add a nested demo #1573
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: 0 B Total Size: 250 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm <3
What I did
Closes #1481
Testing Instructions
Notes to Reviewers
@eyevana here is a demo showing nested tabs working. The bug outlined in #1481 was fixed by our implementation changes from a tabs-controller to aria-tabs-controller upstream in pfe. patternfly/patternfly-elements#2699
Thanks for filling the issue!