Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with push event support #31

Merged
merged 5 commits into from
Apr 26, 2022

Conversation

vitorbal
Copy link
Contributor

@vitorbal vitorbal commented Mar 1, 2022

Hello! First of all, thank you for your work on this action! :)

After the changes in this PR, this action should now work properly for push events as well. That's because we now fallback to grabbing the sha from github.context.sha, which will work for push events!

I've updated the README to reflect this.

I also noticed that the github workflows were still referencing a master branch, but that branch was renamed to main. I pushed a commit to fix that too. Thank you!

@vitorbal
Copy link
Contributor Author

@patrickedqvist 👋 just checking in if you think there's anything else I could do to help land this? Thank you!

@patrickedqvist
Copy link
Owner

@vitorbal Thanks for checking in.

Could you also update the action.yml?

@vitorbal
Copy link
Contributor Author

@patrickedqvist done!

@patrickedqvist patrickedqvist merged commit fc9a362 into patrickedqvist:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants