-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support password-protected vercel deployments #26
Conversation
@JoshBarr Thank you so much for your contribution! Unsolicited PRs are more than welcome since I don't always have the time to add new features myself. I scrolled through your changes which looks good but I'm going to make a more thorough review soon. |
Thanks Patrick! Let me know if there's things I can improve, clarify or change to fit with your plans for this library, too! :) I've updated the If you re-run the workflow (it needs approval), we should get an automatic comment on the PR with our coverage metrics. |
It looks like the coverage reporting step failed. I've reverted that change for now. |
I fixed another edge case: when fetching the initial list of deployments for the PR, it's possible that the |
Hey @patrickedqvist, thanks for making this library!
I'm sure you love unsolicited PRs as much as any other maintainer 😅 Apologies in advance!
We've been looking for a way to run our e2e tests against the preview URL for a while. We password protect all our preview deployments, so we needed a way sign in programmtically inside the action.
Here's a summary of what's changed:
Functional changes
vercel_password
input, which is used to obtain a_vercel_jwt
cookie for browsing authenticated sites.bug fixes
vercel[bot]
rather than just taking the first deployment.setFailure()
, which sometimes resulted in double errorsdev experience and CI
node_modules
from the package, in favour of compiling the project with ncc. This is apparently how GitHub build most of their actions.