Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: createMagicLink now correctly transforms the "userId" parameter #205

Merged
merged 1 commit into from
Dec 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/classes/Auth/Auth.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ export class Auth extends PassageBase {
try {
const { language, magicLinkPath, redirectUrl, ttl } = options ?? {};

let userId: string | undefined = undefined;
let channel: MagicLinkChannel;
if ('userId' in args) {
userId = args.userId;
channel = args.channel;
} else if ('email' in args) {
channel = MagicLinkChannel.Email;
Expand All @@ -96,11 +98,13 @@ export class Auth extends PassageBase {
appId: this.config.appId,
createMagicLinkRequest: {
...args,
// eslint-disable-next-line camelcase
user_id: userId,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was being passed as part of the ...args input, but the codegen wants this instead

channel,
language,
magic_link_path: magicLinkPath,
redirect_url: redirectUrl,
ttl,
channel,
},
});

Expand Down
Loading