fix: createMagicLink now correctly transforms the "userId" parameter #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctran88
requested review from
flanagankp and
a team
and removed request for
flanagankp
ctran88
force-pushed
the
PSG-5578-fix-create-magic-link-user-id-param
branch
from
5e7ef8f to
8064b24
Compare
ctran88
force-pushed
the
PSG-5578-fix-create-magic-link-user-id-param
branch
from
8064b24 to
4553f16
Compare
ctran88
commented
Dec 14, 2024
| @@ -96,11 +98,13 @@ export class Auth extends PassageBase { | |||
| appId: this.config.appId, | |||
| createMagicLinkRequest: { | |||
| ...args, | |||
| // eslint-disable-next-line camelcase | |||
| user_id: userId, | |||
There was a problem hiding this comment.
it was being passed as part of the ...args input, but the codegen wants this instead
|
flanagankp
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
This was a bug in v2.12.0 where the argument name for
MagicLinkWithUserArgswasuserId, which was being passed directly to our api, which wanteduser_idinstead.Screenshots (if appropriate):
Type of change
Checklist:
Additional context