[Feat] Added simulated readout error routines #23

madagra · 2023-10-02T14:34:27Z

Deprecated. This will be closed soon.

Add constructors

Digital decomposition, operations and Braket backend

Files

add utils.py file

* Add README. * Remove useless heading.

Co-authored-by: Kaonan Micadei <[email protected]> Co-authored-by: Vytautas Abramavicius <[email protected]>

* state preparation * logging * register * execution helpers * qubit support * serialization * typing * wavefunction overlaps Co-authored-by: Aleksander Wennersteen <[email protected]> Co-authored-by: Mario Dagrada <[email protected]> Co-authored-by: Vincent Elfving <[email protected]> Co-authored-by: Dominik Seitz <[email protected]> Co-authored-by: Joao Moutinho <[email protected]> Co-authored-by: Vytautas Abramavicius <[email protected]> Co-authored-by: Niklas Heim <[email protected]> Co-authored-by: Roland Guichard <[email protected]>

Co-authored-by: Aleksander Wennersteen <[email protected]> Co-authored-by: Mario Dagrada <[email protected]> Co-authored-by: Vincent Elfving <[email protected]> Co-authored-by: Gert-Jan Both <[email protected]>

* Docs suggestions. * Fix typo. * Latest changes. * Latest changes. * Trigger docs tests on CI. * More files to docs. * fix circuit drawings * quadance to qadance * More docs improvements. * fix docs build * More suggestions and run test-docs again. * update pulser examples * remove mkdocs-jupyter * update pulser example * More improvements. --------- Co-authored-by: jpmoutinho <[email protected]> Co-authored-by: João P. Moutinho <[email protected]> Co-authored-by: Vytautas Abramavicius <[email protected]>

* update readme * remove admonition * lint --------- Co-authored-by: Roland Guichard <[email protected]>

* Improvements to the Pulser backend documents + change defaults * Shorter names to the workflows * Linting * Improvements to the docs * Added AnalogRZ operation to the enumeration * Go back to idealized device --------- Co-authored-by: Roland Guichard <[email protected]>

Co-authored-by: Aleksander Wennersteen <[email protected]>

Co-authored-by: Aleksander Wennersteen <[email protected]> Co-authored-by: Mario Dagrada <[email protected]>

* Docs suggestions. * Fix typo. * Latest changes. * Latest changes. * Trigger docs tests on CI. * More files to docs. * fix circuit drawings * quadance to qadance * More docs improvements. * fix docs build * More suggestions and run test-docs again. * update pulser examples * remove mkdocs-jupyter * update pulser example * More improvements. * Fix lint. * More docs suggestions. * More and more suggestions. * More suggestions. * More suggestions. * Concatenate two doc files. * Move to qml_tools.md * More suggestions. * update entanglement tests * few fixes * pulser-basic tutorial broken * few fixes * few fixes * more fixes * remove total_magnetization from docs * remove emuc * fix entanglement test * fix entanglement test * Update docs/advanced_tutorials/custom-models.md * Update docs/advanced_tutorials/differentiability.md * Update docs/digital_analog_qc/pulser-basic.md * Update docs/tutorials/ml_tools.md * Update docs/tutorials/qml_tools.md * Update docs/tutorials/ml_tools.md * Update docs/tutorials/qml_tools.md * Update docs/tutorials/serializ_and_prep.md * More suggestions. * Fix conflicts. --------- Co-authored-by: jpmoutinho <[email protected]> Co-authored-by: João P. Moutinho <[email protected]> Co-authored-by: Vytautas Abramavicius <[email protected]>

RolandMacDoland

Thanks @madagra. Here are some uncomplete suggestions. If you approve them, I'll take this work over.

RolandMacDoland · 2023-10-09T15:23:19Z

qadence/backend.py

    @abstractmethod
-    def _overlap(bras: Tensor, kets: Tensor) -> Tensor:
+    def overlap(self, bra: QuantumCircuit, ket: Optional[QuantumCircuit] = None) -> Tensor:


Suggested change

def overlap(self, bra: QuantumCircuit, ket: Optional[QuantumCircuit] = None) -> Tensor:

def overlap(self, bra: QuantumCircuit, ket: QuantumCircuit | None = None) -> Tensor:

RolandMacDoland · 2023-10-09T15:23:40Z

qadence/models/quantum_model.py

@@ -49,6 +50,7 @@ def __init__(
        diff_mode: DiffMode = DiffMode.AD,
        protocol: Measurements | None = None,
        configuration: BackendConfiguration | dict | None = None,
+        noise_model: ErrorModel | None = None,


Suggested change

noise_model: ErrorModel | None = None,

error_model: ErrorModel | None = None,

RolandMacDoland · 2023-10-09T15:23:55Z

qadence/models/quantum_model.py

@@ -62,6 +64,7 @@ def __init__(
            protocol: Optional measurement protocol. If None, use
                exact expectation value with a statevector simulator.
            configuration: Configuration for the backend.
+            noise_model: Whether or not and which noise model to use.


Suggested change

noise_model: Whether or not and which noise model to use.

error_model: Whether or not and which noise model to use.

RolandMacDoland · 2023-10-09T15:24:36Z

qadence/models/quantum_model.py

@@ -93,6 +95,8 @@ def __init__(
        self._backend_name = backend
        self._diff_mode = diff_mode
        self._protocol = protocol
+        self._noise_model = noise_model


Suggested change

self._noise_model = noise_model

self._error_model = error_model

RolandMacDoland · 2023-10-09T15:25:51Z

qadence/models/quantum_model.py

+        if self._noise_model is None:
+            return output
+        # corrupt bitstrings with simple readout noise
+        elif self._noise_model.name == "ReadoutError":


That's the point: readout errors aren't generated by noise. I think naming everything error_model makes it more generic.

RolandMacDoland · 2023-10-09T15:27:22Z

qadence/noise.py

+    """White noise distributions"""
+
+    UNIFORM = staticmethod(uniform.Uniform(low=0.0, high=1.0))
+    "uniform white noise"


Suggested change

"uniform white noise"

"""Uniform white noise."""

RolandMacDoland · 2023-10-09T15:27:36Z

qadence/noise.py

+    "uniform white noise"
+
+    GAUSSIAN = staticmethod(normal.Normal(loc=0.0, scale=1.0))
+    "gaussian white noise"


Suggested change

"gaussian white noise"

"""Gaussian white noise."""

RolandMacDoland · 2023-10-09T15:27:56Z

qadence/noise.py

+    "gaussian white noise"
+
+    POISSON = staticmethod(poisson.Poisson(rate=0.1))
+    "poisson white noise"


Suggested change

"poisson white noise"

"""Poisson white noise."""

RolandMacDoland · 2023-10-09T15:28:22Z

qadence/noise.py

+    name = "ErrorModel"
+
+    @abstractmethod
+    def bit_flip(self, qbit: int) -> int:


Suggested change

def bit_flip(self, qbit: int) -> int:

def bit_flip(self, qubit: int) -> int:

RolandMacDoland · 2023-10-09T15:28:31Z

qadence/noise.py

+        pass
+
+    @abstractmethod
+    def phase_flip(self, qbit: int) -> int:


Suggested change

def phase_flip(self, qbit: int) -> int:

def phase_flip(self, qubit: int) -> int:

…ch history

madagra · 2023-10-27T07:14:53Z

@Roland-djee please close this one.

jpmoutinho and others added 30 commits October 2, 2023 12:55

constructors

6377bc9

Digital decomposition, operations and Braket backend

383c6f1

Add measurements.

15c475e

Merge branch 'main' into jm/constructors

cd533af

Merge pull request #11 from pasqal-io/jm/constructors

9c28a60

Add constructors

Merge pull request #12 from pasqal-io/md/contribution

0a63666

Digital decomposition, operations and Braket backend

dominik files

f2a491f

pyqtorch; draw; models; transpile

bae5688

Merge pull request #13 from pasqal-io/ds/dominik

e6835e9

Files

Added infrastructure and build files

145ef6b

Cleanup

b8ee23a

block_to_tensor

943dece

matrixblock

9192e8b

add utils.py file

bc48393

new draw; more blocks

c2b6b6f

Merge pull request #14 from pasqal-io/em/blocks_utils

35163e5

add utils.py file

Add README. (#15)

dd4e621

remaining backends files

cf5b3fb

Rg/add readme (#16)

560b3c2

* Add README. * Remove useless heading.

gpsr algorithm

1f1c65d

pulser backend

73825cf

Co-authored-by: Kaonan Micadei <[email protected]> Co-authored-by: Vytautas Abramavicius <[email protected]>

draw requirements; install instructions

a85c79b

Merge branch 'main' of github.com:pasqal-io/qadence

c1c4461

Remove refs to private repo.

c36f97b

Create a coverage report as XML file.

d73b9a1

Update pyproject.toml

e87857c

added co-author

14ea1e5

Added abstract block

24120f7

Co-authored-by: Aleksander Wennersteen <[email protected]> Co-authored-by: Mario Dagrada <[email protected]> Co-authored-by: Vincent Elfving <[email protected]> Co-authored-by: Gert-Jan Both <[email protected]>

don't exclude py files in docs forlder

2a3a40d

gvelikova assigned gvelikova and unassigned madagra Oct 6, 2023

RolandMacDoland and others added 14 commits October 6, 2023 13:35

Update README and docs/index.md (#38)

bc1bd5e

* update readme * remove admonition * lint --------- Co-authored-by: Roland Guichard <[email protected]>

code of conduct and contributing

c055c3c

fix occurrence

44a5a88

license file

479c7fb

suggestions

be69972

license

ec11338

Add LICENSE, CODE_OF_CONDUCT, CONTRIBUTING

dc6d8c9

Co-authored-by: Aleksander Wennersteen <[email protected]>

Correctly draw analog blocks; improve HamEvo drawings (#36)

fabcde1

Add LICENSE, CODE_OF_CONDUCT, CONTRIBUTING file

8d1753f

Co-authored-by: Aleksander Wennersteen <[email protected]> Co-authored-by: Mario Dagrada <[email protected]>

Merge branch 'main' into ds/conduct

9fb0afe

Add CODE_OF_CONDUCT, CONTRIBUTING, LICENSE files

a6b51bf

RolandMacDoland changed the title ~~Added simulated readout error routines~~ [Feat] Added simulated readout error routines Oct 9, 2023

RolandMacDoland added the realistic-sim label Oct 9, 2023

RolandMacDoland reviewed Oct 9, 2023

View reviewed changes

Merge branch 'main' into gv/readout_errors

c80efac

madagra force-pushed the main branch from 582ffee to 7b15fb6 Compare October 10, 2023 15:55

madagra marked this pull request as draft October 10, 2023 20:52

gvelikova added 3 commits October 16, 2023 18:11

merge

c89b072

Merge branch 'main' into gv/readout_errors

64e16ba

naming updates and restructiring; added for completeness on this bran…

5af37d2

…ch history

RolandMacDoland mentioned this pull request Oct 23, 2023

[Feature] Implementation of noise protocol. #128

Merged

7 tasks

madagra assigned RolandMacDoland Oct 27, 2023

gvelikova closed this Oct 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feat] Added simulated readout error routines #23

[Feat] Added simulated readout error routines #23

madagra commented Oct 2, 2023 •

edited

Loading

RolandMacDoland left a comment

RolandMacDoland Oct 9, 2023

RolandMacDoland Oct 9, 2023

RolandMacDoland Oct 9, 2023

RolandMacDoland Oct 9, 2023

RolandMacDoland Oct 9, 2023

RolandMacDoland Oct 9, 2023

RolandMacDoland Oct 9, 2023

RolandMacDoland Oct 9, 2023

RolandMacDoland Oct 9, 2023

RolandMacDoland Oct 9, 2023

madagra commented Oct 27, 2023

	def overlap(self, bra: QuantumCircuit, ket: Optional[QuantumCircuit] = None) -> Tensor:
	def overlap(self, bra: QuantumCircuit, ket: QuantumCircuit \| None = None) -> Tensor:

	noise_model: ErrorModel \| None = None,
	error_model: ErrorModel \| None = None,

	noise_model: Whether or not and which noise model to use.
	error_model: Whether or not and which noise model to use.

	self._noise_model = noise_model
	self._error_model = error_model

	def bit_flip(self, qbit: int) -> int:
	def bit_flip(self, qubit: int) -> int:

	def phase_flip(self, qbit: int) -> int:
	def phase_flip(self, qubit: int) -> int:

[Feat] Added simulated readout error routines #23

[Feat] Added simulated readout error routines #23

Conversation

madagra commented Oct 2, 2023 • edited Loading

RolandMacDoland left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

madagra commented Oct 27, 2023

madagra commented Oct 2, 2023 •

edited

Loading