-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Implementation of noise protocol. #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
RolandMacDoland
changed the title
First attempt at error protocol.
[Feat] First attempt at error protocol.
Oct 26, 2023
Docstrings and proper tests remaining too :). |
gvelikova
reviewed
Nov 7, 2023
gvelikova
reviewed
Nov 8, 2023
gvelikova
reviewed
Nov 8, 2023
nmheim
reviewed
Nov 8, 2023
RolandMacDoland
commented
Nov 8, 2023
madagra
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, but overall looks good to me @gvelikova and @Roland-djee.
gvelikova
reviewed
Nov 9, 2023
Thanks @gvelikova. If it passes, you can hit the merge button :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48, rework of #23.
@gvelikova This is ready for you to take over. As discussed, there are the following points:
./errors/errors.py
->./exceptions/exceptions.py
DifferentiableBackend
sample
ie.Measurements
Hope that makes sense.