Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implementation of noise protocol. #128

Merged
merged 95 commits into from
Nov 9, 2023
Merged

Conversation

RolandMacDoland
Copy link
Collaborator

@RolandMacDoland RolandMacDoland commented Oct 23, 2023

Closes #48, rework of #23.

@gvelikova This is ready for you to take over. As discussed, there are the following points:

  • Move ./errors/errors.py -> ./exceptions/exceptions.py
  • Change protocol occurrences to measurement from/in qadence.measurements to remove ambiguity including DifferentiableBackend
  • Harmonise across all backends
  • Test the sample corruption from backends and quantum model
  • Close [Feat] Added simulated readout error routines #23 whenever you feel so
  • Test with other protocols that require sample ie. Measurements
  • Add on sampling with readout error in the documentation.

Hope that makes sense.

@RolandMacDoland RolandMacDoland marked this pull request as draft October 24, 2023 13:32
@RolandMacDoland RolandMacDoland added the feature New feature or request label Oct 26, 2023
@RolandMacDoland RolandMacDoland changed the title First attempt at error protocol. [Feat] First attempt at error protocol. Oct 26, 2023
@gvelikova
Copy link
Collaborator

Docstrings and proper tests remaining too :).

@gvelikova gvelikova requested review from madagra and removed request for gvelikova October 31, 2023 09:05
qadence/noise/readout.py Outdated Show resolved Hide resolved
tests/qadence/test_error_models.py Show resolved Hide resolved
qadence/noise/protocols.py Show resolved Hide resolved
qadence/noise/readout.py Show resolved Hide resolved
Copy link
Collaborator

@madagra madagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but overall looks good to me @gvelikova and @Roland-djee.

qadence/backends/braket/backend.py Outdated Show resolved Hide resolved
qadence/backends/pulser/backend.py Outdated Show resolved Hide resolved
qadence/backends/pulser/backend.py Outdated Show resolved Hide resolved
qadence/backends/pyqtorch/backend.py Outdated Show resolved Hide resolved
qadence/noise/readout.py Outdated Show resolved Hide resolved
qadence/noise/readout.py Outdated Show resolved Hide resolved
@RolandMacDoland
Copy link
Collaborator Author

Thanks @gvelikova. If it passes, you can hit the merge button :)

@gvelikova gvelikova merged commit 96eb632 into main Nov 9, 2023
7 checks passed
@gvelikova gvelikova deleted the rg/errors-module branch November 9, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request realistic-sim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulate readout errors
5 participants