[Refactoring] Enforce dimensionless parameter values passed to GPSR function #266
Labels
refactoring
Refactoring of legacy code
to_check
To check in the development of the new expression system.
Currently when using
HamEvo
blocks with GPSR, the differentiable parameter can have arbitrary dimension, however GPSR shifts are have the dimension of angle. This results in incorrect application of GPSR.Possible solution can be enforcing all the blocks to have unitaries conforming to definition of GPSR paper -
U(x)=exp(-(i/2)*x*G)
. This wayx
would always be an angle and GPSR would be applied correctly.The text was updated successfully, but these errors were encountered: