Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring] Enforce dimensionless parameter values passed to GPSR function #266

Open
vytautas-a opened this issue Dec 13, 2023 · 3 comments
Assignees
Labels
refactoring Refactoring of legacy code to_check To check in the development of the new expression system.

Comments

@vytautas-a
Copy link
Collaborator

Currently when using HamEvo blocks with GPSR, the differentiable parameter can have arbitrary dimension, however GPSR shifts are have the dimension of angle. This results in incorrect application of GPSR.

Possible solution can be enforcing all the blocks to have unitaries conforming to definition of GPSR paper - U(x)=exp(-(i/2)*x*G). This way x would always be an angle and GPSR would be applied correctly.

@jpmoutinho jpmoutinho added the refactoring Refactoring of legacy code label Dec 13, 2023
@RolandMacDoland
Copy link
Collaborator

RolandMacDoland commented Feb 7, 2024

@jpmoutinho @vytautas-a will this be picked up anytime soon ?

@RolandMacDoland RolandMacDoland changed the title Enforce dimensionless parameter values passed to GPSR function [Refactoring] Enforce dimensionless parameter values passed to GPSR function Feb 7, 2024
@jpmoutinho
Copy link
Collaborator

I would work on this once the structure / purpose of the analog blocks is bit cleaner. Alternatively it can be something for @vytautas-a once he has some time from his current project.

@mlahariya
Copy link
Collaborator

@jpmoutinho - please review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of legacy code to_check To check in the development of the new expression system.
Projects
None yet
Development

No branches or pull requests

4 participants