Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] GPSR and Hamevo compatibility #238

Closed
chMoussa opened this issue Jul 19, 2024 · 4 comments
Closed

[Feature] GPSR and Hamevo compatibility #238

chMoussa opened this issue Jul 19, 2024 · 4 comments
Assignees
Labels
feature New feature or request

Comments

@chMoussa
Copy link
Collaborator

Check/Make Hamevo compatible with GPSR and add tests

@chMoussa chMoussa self-assigned this Jul 19, 2024
@chMoussa chMoussa added the feature New feature or request label Jul 19, 2024
@jpmoutinho
Copy link
Collaborator

Some relevant Qadence issues:
pasqal-io/qadence#266
pasqal-io/qadence#397

@rajaiitp
Copy link
Collaborator

I will point out a usecase where gpsr is not supposed to work, just so that its not something you try to work with.
$$ H = \alpha X + Z $$

Gpsr will not give the derivative wrt to \alpha for hamevo(H), because it does not scale the full generator of the unitary it is a part of.

@jpmoutinho
Copy link
Collaborator

Yes @rajaiitp this was my point that GPSR assumes something like $G.x$ while in the code we allow generators with an arbitrary dependence $G(x)$ to be written.

@chMoussa
Copy link
Collaborator Author

chMoussa commented Aug 9, 2024

Closing with #255

@chMoussa chMoussa closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants