Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] HamiltonianEvolution supported in GPSR with fixed generators #255

Merged
merged 92 commits into from
Aug 9, 2024
Merged

[Feature] HamiltonianEvolution supported in GPSR with fixed generators #255

merged 92 commits into from
Aug 9, 2024

Conversation

chMoussa
Copy link
Collaborator

@chMoussa chMoussa commented Aug 7, 2024

No description provided.

dominikandreasseitz and others added 30 commits July 3, 2024 14:01
@dominikandreasseitz
[Feature] Single gap GPSR
0ee2a50
@dominikandreasseitz
rm file
5cbe904
@dominikandreasseitz
Merge branch 'main' into ds/singlegap_psr
621fe48
@dominikandreasseitz
activate
608bd30
fix missing grad tol
a8ab9b6
@dominikandreasseitz
[Feature] SingleGap GPSR
45363e2
Merge remote-tracking branch 'origin/main' into ds/singlegapgpsr_2
4b25446
Merge remote-tracking branch 'origin/main' into ds/singlegapgpsr_2
68a16a0
fix call grad grad gpsr
ab632a0
fix order call gpsr state obs and tests
61b9b90
fix grads not giving same shape when using repeated params
4dee7b4
use None for param dict
37f9a45
Merge remote-tracking branch 'origin/main' into ds/singlegapgpsr_2
ed2a042
separate diff tests + check psr for sequences
639639a
handling cases with repeated params in vjp
ce8e155
docstrings for psr
d5a1c85
add layer to etst_diff_adjoint
92c4e80
use uuid instead of temp
4027a60
use uuid only as temp
3edff45
adding example of higher order failing
cd1d40a
removing changing op name in gpsr as compiler will handle it
72750a8
Merge remote-tracking branch 'origin/main' into ds/singlegapgpsr_2
4f1b904
only str param_name to check support gpsr
f676183
add multigap
9961e5a
change diff circuit
6e8acae
test multigap gpsr
81f47e2
@chMoussa @RolandMacDoland
Update pyqtorch/gpsr.py
3dd768a 
Co-authored-by: Roland-djee <[email protected]>
@chMoussa @RolandMacDoland
Update pyqtorch/gpsr.py
2c84821 
Co-authored-by: Roland-djee <[email protected]>
@chMoussa @RolandMacDoland
Update pyqtorch/gpsr.py
256ad81 
Co-authored-by: Roland-djee <[email protected]>
@chMoussa @RolandMacDoland
Update pyqtorch/gpsr.py
20cb871 
Co-authored-by: Roland-djee <[email protected]>
@chMoussa chMoussa added the feature New feature or request label Aug 7, 2024
@chMoussa chMoussa self-assigned this Aug 7, 2024
@chMoussa chMoussa marked this pull request as ready for review August 8, 2024 17:02
@RolandMacDoland RolandMacDoland self-requested a review August 9, 2024 09:26
@chMoussa chMoussa requested a review from jpmoutinho August 9, 2024 10:08
jpmoutinho
jpmoutinho reviewed Aug 9, 2024
View reviewed changes
pyqtorch/matrices.py Outdated Show resolved Hide resolved
pyqtorch/matrices.py Show resolved Hide resolved
pyqtorch/primitive.py Outdated Show resolved Hide resolved
RolandMacDoland
RolandMacDoland approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not much to add from @jpmoutinho's comments.

@chMoussa chMoussa merged commit 8ec5df1 into main Aug 9, 2024
9 checks passed
@chMoussa chMoussa deleted the cm/hamevo_diff branch August 9, 2024 11:12
This was referenced Aug 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmoutinho jpmoutinho jpmoutinho left review comments

@RolandMacDoland RolandMacDoland RolandMacDoland approved these changes

Assignees

@chMoussa chMoussa

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chMoussa @RolandMacDoland @jpmoutinho @dominikandreasseitz @vytautas-a