Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Single gap GPSR #213

Merged
merged 12 commits into from
Jul 4, 2024
Merged

[Feature] Single gap GPSR #213

merged 12 commits into from
Jul 4, 2024

Conversation

dominikandreasseitz
Copy link
Collaborator

No description provided.

@dominikandreasseitz dominikandreasseitz added the feature New feature or request label Jul 3, 2024
@dominikandreasseitz dominikandreasseitz self-assigned this Jul 3, 2024
@chMoussa chMoussa self-requested a review July 3, 2024 12:44
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dominikandreasseitz looking good. Please bear in mind that after the earlier discussion, it will certainly serve as a template for Horqrux's implementation (@gvelikova ). @chMoussa happy to proceed quickly for the multi-gap case.

docs/differentiation.md Outdated Show resolved Hide resolved
pyqtorch/gpsr.py Outdated Show resolved Hide resolved
@chMoussa chMoussa merged commit 7e38f2e into main Jul 4, 2024
9 checks passed
@chMoussa chMoussa deleted the ds/singlegap_psr branch July 4, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants