Improve access to output modulation durations #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
a-corni
approved these changes
Apr 3, 2024
tutorials/advanced_features/Output Modulation and EOM Mode.ipynb
Outdated
Show resolved
Hide resolved
Co-authored-by: Antoine Cornillot <[email protected]>
soufianekaghad98
pushed a commit
to soufianekaghad98/Pulser
that referenced
this pull request
Apr 25, 2024
* Add option to delay after pulse modulation * Deal with delay of 0 * Add Pulse.get_full_duration() * Update the Output Modulation tutorial * Add at_rest option to align() * Update JSON schema * Update tutorials/advanced_features/Output Modulation and EOM Mode.ipynb Co-authored-by: Antoine Cornillot <[email protected]> --------- Co-authored-by: Antoine Cornillot <[email protected]>
Merged
HGSilveri
added a commit
that referenced
this pull request
Apr 29, 2024
Main changes: 21a47f3 Remove Register.rotate() (#642) 20e6765 FIX: Redefine slope of RampWaveform (#644) c2d5b6c Enabling definition of multiple noise channels and noise channels in XY (#647) bcb78cc Enable digital simulation (#652) 0f6e3dd Improve access to output modulation durations (#663) 188d21d Remove deprecated noise arguments (#674) f303138 Adding relaxation noise channel (#675) 716b86b Centralize all backend imports from a single pulser.backends module (#678) 96a8c34 Add hyperfine dephasing rate to NoiseModel (#680) 4981ca6 Add optional default noise models to devices (#676) c695373 Rectangular lattice register and layout (#665)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at_rest: booloption toSequence.delay()andSequence.align()to wait (or not) for a pulse to truly finishPulse.get_full_duration()to access the full duration of a pulse after modulation, as shown in the sequence drawing.at_restargumentCloses #643 .