Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable digital simulation #652

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Enable digital simulation #652

merged 1 commit into from
Mar 1, 2024

Conversation

a-corni
Copy link
Collaborator

@a-corni a-corni commented Feb 28, 2024

Grabbing the hanging fruit: everything was already here to enable simulation in digital mode.

@a-corni a-corni requested a review from HGSilveri February 28, 2024 09:39
@a-corni
Copy link
Collaborator Author

a-corni commented Feb 28, 2024

Another hanging fruit: simulation with effective collapse operators in "all" simulation. I intend to tackle it in another PR, where I would also tackle the implementation of dephasing noise - that needs more structural change - but can also do it here since it does not require much. What is your opinion on this @HGSilveri ?

Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@HGSilveri
Copy link
Collaborator

Another hanging fruit: simulation with effective collapse operators in "all" simulation. I intend to tackle it in another PR, where I would also tackle the implementation of dephasing noise - that needs more structural change - but can also do it here since it does not require much. What is your opinion on this @HGSilveri ?

I think this warrants a new PR, let's keep this one small

@a-corni a-corni merged commit bcb78cc into develop Mar 1, 2024
7 checks passed
@HGSilveri HGSilveri deleted the digital_sim branch April 15, 2024 09:52
@HGSilveri HGSilveri mentioned this pull request Apr 29, 2024
HGSilveri added a commit that referenced this pull request Apr 29, 2024
Main changes:

21a47f3 Remove Register.rotate() (#642)
20e6765 FIX: Redefine slope of RampWaveform (#644)
c2d5b6c Enabling definition of multiple noise channels and noise channels in XY (#647)
bcb78cc Enable digital simulation (#652)
0f6e3dd Improve access to output modulation durations (#663)
188d21d Remove deprecated noise arguments (#674)
f303138 Adding relaxation noise channel (#675)
716b86b Centralize all backend imports from a single pulser.backends module (#678)
96a8c34 Add hyperfine dephasing rate to NoiseModel (#680)
4981ca6 Add optional default noise models to devices (#676)
c695373 Rectangular lattice register and layout (#665)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants