Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Layout updates #424

Merged
merged 7 commits into from
Dec 1, 2022
Merged

Register Layout updates #424

merged 7 commits into from
Dec 1, 2022

Conversation

HGSilveri
Copy link
Collaborator

Closes #420 #414 .

@HGSilveri HGSilveri requested a review from CdeTerra November 30, 2022 17:35
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@HGSilveri HGSilveri linked an issue Nov 30, 2022 that may be closed by this pull request
@HGSilveri HGSilveri marked this pull request as ready for review November 30, 2022 17:52
@HGSilveri
Copy link
Collaborator Author

I just noticed that the code highlighting in the notebooks is broken. This seems to be related to the latest update of ipython, as mentioned here.

For now, I'll just avoid that version.

Copy link
Collaborator

@CdeTerra CdeTerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tutorial!

tutorials/advanced_features/Register Layouts.ipynb Outdated Show resolved Hide resolved
@HGSilveri HGSilveri merged commit 6b7a2f1 into develop Dec 1, 2022
@HGSilveri HGSilveri deleted the layout-updates branch December 1, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RegisterLayout updates Add the RegisterLayout slug to the abstract representation serializer
2 participants