Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the RegisterLayout slug to the abstract representation serializer #414

Closed
HGSilveri opened this issue Oct 28, 2022 · 0 comments · Fixed by #424
Closed

Add the RegisterLayout slug to the abstract representation serializer #414

HGSilveri opened this issue Oct 28, 2022 · 0 comments · Fixed by #424
Assignees
@vytautas-ab
Labels
good first issue Good for newcomers
Milestone
v0.8 Release

Comments

@HGSilveri
Copy link
Collaborator

The new schema introduced in PR #412 already has an optional slug field for the layout. Once that is merged, we can include the slug parameter introduced in #411 in the RegisterLayout serialization.
@HGSilveri HGSilveri self-assigned this Oct 28, 2022
@HGSilveri HGSilveri added the good first issue Good for newcomers label Oct 31, 2022
@HGSilveri HGSilveri removed their assignment Oct 31, 2022
@HGSilveri HGSilveri added this to the v0.8 Release milestone Nov 28, 2022
@HGSilveri HGSilveri mentioned this issue Nov 30, 2022
Merged
@HGSilveri HGSilveri linked a pull request Nov 30, 2022 that will close this issue
Register Layout updates #424
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vytautas-ab vytautas-ab

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v0.8 Release
Development

Successfully merging a pull request may close this issue.

Register Layout updates pasqal-io/Pulser
2 participants
@vytautas-ab @HGSilveri