Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge '[Electron] Optional feature to use HSE/LSI as RTC clock source instead of LSE (external 32KHz XTAL)' into develop #2360

Merged
merged 6 commits into from
Sep 28, 2021
Merged

Merge '[Electron] Optional feature to use HSE/LSI as RTC clock source instead of LSE (external 32KHz XTAL)' into develop #2360

merged 6 commits into from
Sep 28, 2021

Conversation

keeramis
Copy link
Contributor

@keeramis keeramis commented Sep 28, 2021 •
edited
Loading

Description

This PR contains the commits ported retroactively from 2.0.2 to develop. Please see #2354

Steps to Test

References

#2354

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@keeramis keeramis changed the title Feature/electron no lse develop Merge [Electron] Optional feature to use HSE/LSI as RTC clock source instead of LSE (external 32KHz XTAL) into develop Sep 28, 2021
@keeramis
Copy link
Contributor Author

cc: @avtolstoy for visibility.

@keeramis keeramis changed the title Merge [Electron] Optional feature to use HSE/LSI as RTC clock source instead of LSE (external 32KHz XTAL) into develop Merge '[Electron] Optional feature to use HSE/LSI as RTC clock source instead of LSE (external 32KHz XTAL)' into develop Sep 28, 2021
@technobly technobly added ready to merge PR has been reviewed and tested and removed needs review labels Sep 28, 2021
@keeramis keeramis force-pushed the feature/electron-no-lse-develop branch from 2df08b1 to 4f7a104 Compare September 28, 2021 19:05
@keeramis keeramis force-pushed the feature/electron-no-lse-develop branch from 4f7a104 to 3a26233 Compare September 28, 2021 21:24
@keeramis keeramis merged commit e172642 into develop Sep 28, 2021
@keeramis keeramis deleted the feature/electron-no-lse-develop branch September 28, 2021 22:09
@technobly technobly restored the feature/electron-no-lse-develop branch September 29, 2021 00:41
@technobly technobly mentioned this pull request Sep 29, 2021
Merged
@keeramis keeramis deleted the feature/electron-no-lse-develop branch September 29, 2021 15:26
@keeramis keeramis mentioned this pull request Sep 29, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technobly technobly technobly approved these changes

@XuGuohui XuGuohui Awaiting requested review from XuGuohui

@avtolstoy avtolstoy Awaiting requested review from avtolstoy

Assignees
No one assigned
Labels
ready to merge PR has been reviewed and tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keeramis @technobly @avtolstoy