[Electron] Optional feature to use HSE/LSI as RTC clock source instead of LSE (external 32KHz XTAL) #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuGuohui
reviewed
Sep 13, 2021
| @@ -84,21 +101,187 @@ void HAL_RTC_Initialize_UnixTime() | |||
| /* Get calendar_time date struct values */ | |||
| RTC_DateStructure.RTC_WeekDay = 6; | |||
| RTC_DateStructure.RTC_Date = 1; | |||
| RTC_DateStructure.RTC_Month = 0; | |||
| RTC_DateStructure.RTC_Month = 1; | |||
There was a problem hiding this comment.
Just to double confirm that the month starts from 1, since the month field in some RTC chip varies from 0 ~ 11, which is corresponding to month 1 ~ 12.
There was a problem hiding this comment.
Here, it's actually expected to start with 1. Previously the date ended up being Dec 1999 instead of Jan 2000.
hal/src/stm32f2xx/rtc_hal.c
Outdated
|
|
||
| static bool hal_rtc_switch_clock_source(uint32_t source) | ||
| { | ||
| if ((RCC->BDCR & 0x00000300) != (source & 0x300) && (RCC->BDCR & 0x00000300) != 0x000) |
| RTC_DateStructure.RTC_Year = 0; | ||
|
|
||
| setRTCTime(&RTC_TimeStructure, &RTC_DateStructure); | ||
| } | ||
|
|
||
| static void hal_rtc_configure() |
There was a problem hiding this comment.
Prefer to return something in case of failure to conditionally execute following procedures.
| } | ||
| } | ||
|
|
||
| static void hal_rtc_configure_clock() |
There was a problem hiding this comment.
Prefer to return something in case of failure to conditionally execute following procedures.
There was a problem hiding this comment.
This is handled by asserts.
|
|
||
| RCC_RTCCLKConfig(source); | ||
|
|
||
| hal_rtc_configure(); |
XuGuohui
approved these changes
Sep 14, 2021
6 tasks
technobly
approved these changes
Sep 28, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently targets v2.0.1 branch for review, DO NOT MERGE
Description
As title says.
Steps to Test
wiring/electron_disable_external_rtc_clockandwiring/electron_enable_external_rtc_clockwith device-os-test. This can easily be done withelectron_disable_external_rtc_clockfilter i.e.device-os-test run electron electron_disable_external_rtc_clockSystem.enableFeature(FEATURE_DISABLE_EXTERNAL_LOW_SPEED_CLOCK)(this is best done through Concourse, the pipeline has been updated to run Electron tests with LSE and with HSE/LSI). The same thing can be done locally withdevice-os-test --device-os-dir=/path/to/device-os run electronSystem.enableFeature(FEATURE_DISABLE_EXTERNAL_LOW_SPEED_CLOCK)Example App
References
N/A
Completeness