[Security Solution][Admin][AVC Banner] AVC banner logic moved into a …

…kbn package (elastic#188359) - [x] This is an improvement pr to move all the avc banner logic into a reusable kibana package (security solution and fleet integrations) - [x] Compresses the svg used in the banner's background - [x] Fixes a bug where the blog link didn't previously open in a new tab --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 14498a0)
parkiino · Jul 23, 2024 · 84cee3f · 84cee3f
1 parent c3a585d
commit 84cee3f
Show file tree

Hide file tree

Showing 21 changed files with 1,851 additions and 727 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
diff --git a/.i18nrc.json b/.i18nrc.json
@@ -7,6 +7,7 @@
     "alertingTypes": "packages/kbn-alerting-types",
     "apmOss": "src/plugins/apm_oss",
     "autocomplete": "packages/kbn-securitysolution-autocomplete/src",
+    "avcBanner": "packages/kbn-avc-banner/src",
     "bfetch": "src/plugins/bfetch",
     "bfetchError": "packages/kbn-bfetch-error",
     "cases": ["packages/kbn-cases-components"],

diff --git a/package.json b/package.json
@@ -178,6 +178,7 @@
     "@kbn/application-usage-test-plugin": "link:x-pack/test/usage_collection/plugins/application_usage_test",
     "@kbn/assets-data-access-plugin": "link:x-pack/plugins/observability_solution/assets_data_access",
     "@kbn/audit-log-plugin": "link:x-pack/test/security_api_integration/plugins/audit_log",
+    "@kbn/avc-banner": "link:packages/kbn-avc-banner",
     "@kbn/banners-plugin": "link:x-pack/plugins/banners",
     "@kbn/bfetch-error": "link:packages/kbn-bfetch-error",
     "@kbn/bfetch-explorer-plugin": "link:examples/bfetch_explorer",

diff --git a/packages/kbn-avc-banner/README.md b/packages/kbn-avc-banner/README.md
@@ -0,0 +1,3 @@
+# @kbn/avc-banner
+
+`@kbn/avc-banner` is the callout component to showcase the AVC 2024 results Elastic Security recently received for our native Endpoint and encourage users to install Elastic Defend/Endpoint. This package should be delted at EOY 2024.
diff --git a/packages/kbn-avc-banner/index.ts b/packages/kbn-avc-banner/index.ts
@@ -0,0 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+export * from './src';
diff --git a/packages/kbn-avc-banner/jest.config.js b/packages/kbn-avc-banner/jest.config.js
@@ -0,0 +1,13 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+module.exports = {
+  preset: '@kbn/test',
+  rootDir: '../..',
+  roots: ['<rootDir>/packages/kbn-avc-banner'],
+};
diff --git a/packages/kbn-avc-banner/kibana.jsonc b/packages/kbn-avc-banner/kibana.jsonc
@@ -0,0 +1,5 @@
+{
+  "type": "shared-browser",
+  "id": "@kbn/avc-banner",
+  "owner": "@elastic/security-defend-workflows"
+}
diff --git a/packages/kbn-avc-banner/package.json b/packages/kbn-avc-banner/package.json
@@ -0,0 +1,6 @@
+{
+  "name": "@kbn/avc-banner",
+  "private": true,
+  "version": "1.0.0",
+  "license": "SSPL-1.0 OR Elastic License 2.0"
+}
diff --git a/packages/kbn-avc-banner/src/avc_banner_background.svg b/packages/kbn-avc-banner/src/avc_banner_background.svg
diff --git a/packages/kbn-avc-banner/src/custom.d.ts b/packages/kbn-avc-banner/src/custom.d.ts
@@ -0,0 +1,13 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+declare module '*.svg' {
+  const content: string;
+  // eslint-disable-next-line import/no-default-export
+  export default content;
+}
diff --git a/...ts/avc_banner/avc_results_banner_2024.tsx → packages/kbn-avc-banner/src/index.tsx b/...ts/avc_banner/avc_results_banner_2024.tsx → packages/kbn-avc-banner/src/index.tsx
@@ -1,22 +1,23 @@
 /*
  * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
  * or more contributor license agreements. Licensed under the Elastic License
- * 2.0; you may not use this file except in compliance with the Elastic License
- * 2.0.
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
  */
 
 import React from 'react';
 import { css } from '@emotion/css';
 import { i18n } from '@kbn/i18n';
 import { EuiButton, EuiCallOut, EuiSpacer, useEuiTheme } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n-react';
-import { useKibana } from '../../lib/kibana';
+import { useKibana } from '@kbn/kibana-react-plugin/public';
 import avcBannerBackground from './avc_banner_background.svg';
 
 export const AVCResultsBanner2024: React.FC<{ onDismiss: () => void }> = ({ onDismiss }) => {
   const { docLinks } = useKibana().services;
   const { euiTheme } = useEuiTheme();
-  const bannerTitle = i18n.translate('xpack.securitySolution.common.avcResultsBanner.title', {
+  const bannerTitle = i18n.translate('avcBanner.title', {
     defaultMessage: '100% protection with zero false positives.',
   });
 
@@ -38,20 +39,18 @@ export const AVCResultsBanner2024: React.FC<{ onDismiss: () => void }> = ({ onDi
       data-test-subj="avcResultsBanner"
     >
       <FormattedMessage
-        id="xpack.securitySolution.common.avcResultsBanner.body"
+        id="avcBanner.body"
         defaultMessage="Elastic Security shines in Malware Protection Test by AV-Comparatives"
       />
       <EuiSpacer size="s" />
       <EuiButton
         size="s"
         color="success"
-        href={docLinks.links.securitySolution.avcResults}
+        href={docLinks?.links.securitySolution.avcResults}
+        target="_blank"
         data-test-subj="avcReadTheBlog"
       >
-        <FormattedMessage
-          id="xpack.securitySolution.common.avcResults.readTheBlog.link"
-          defaultMessage="Read the blog"
-        />
+        <FormattedMessage id="avcBanner.readTheBlog.link" defaultMessage="Read the blog" />
       </EuiButton>
     </EuiCallOut>
   );

diff --git a/packages/kbn-avc-banner/tsconfig.json b/packages/kbn-avc-banner/tsconfig.json
@@ -0,0 +1,23 @@
+{
+  "extends": "../../tsconfig.base.json",
+  "compilerOptions": {
+    "outDir": "target/types",
+    "types": [
+      "jest",
+      "node",
+      "react"
+    ]
+  },
+  "include": [
+    "**/*.ts",
+    "**/*.tsx",
+  ],
+  "exclude": [
+    "target/**/*"
+  ],
+  "kbn_references": [
+    "@kbn/i18n",
+    "@kbn/i18n-react",
+    "@kbn/kibana-react-plugin",
+  ]
+}
diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -92,6 +92,8 @@
       "@kbn/assets-data-access-plugin/*": ["x-pack/plugins/observability_solution/assets_data_access/*"],
       "@kbn/audit-log-plugin": ["x-pack/test/security_api_integration/plugins/audit_log"],
       "@kbn/audit-log-plugin/*": ["x-pack/test/security_api_integration/plugins/audit_log/*"],
+      "@kbn/avc-banner": ["packages/kbn-avc-banner"],
+      "@kbn/avc-banner/*": ["packages/kbn-avc-banner/*"],
       "@kbn/axe-config": ["packages/kbn-axe-config"],
       "@kbn/axe-config/*": ["packages/kbn-axe-config/*"],
       "@kbn/babel-preset": ["packages/kbn-babel-preset"],
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		# @kbn/avc-banner

		`@kbn/avc-banner` is the callout component to showcase the AVC 2024 results Elastic Security recently received for our native Endpoint and encourage users to install Elastic Defend/Endpoint. This package should be delted at EOY 2024.