-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package #188359
Conversation
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fleet code LGTM
…into task/avc-banner-package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! nice work on extracting the banner! 🚀
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…kbn package (elastic#188359) - [x] This is an improvement pr to move all the avc banner logic into a reusable kibana package (security solution and fleet integrations) - [x] Compresses the svg used in the banner's background - [x] Fixes a bug where the blog link didn't previously open in a new tab --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 14498a0)
…into a kbn package (#188359) (#188892) # Backport This will backport the following commits from `main` to `8.15`: - [[Security Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package (#188359)](#188359) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Candace Park","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-18T23:24:28Z","message":"[Security Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package (#188359)\n\n## Summary\r\n\r\n- [x] This is an improvement pr to move all the avc banner logic into a\r\nreusable kibana package (security solution and fleet integrations)\r\n- [x] Compresses the svg used in the banner's background \r\n- [x] Fixes a bug where the blog link didn't previously open in a new\r\ntab\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"14498a02214fbd312ad79497783b15ac7deb3b2b","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Defend Workflows","auto-backport","v8.15.0"],"number":188359,"url":"https://github.com/elastic/kibana/pull/188359","mergeCommit":{"message":"[Security Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package (#188359)\n\n## Summary\r\n\r\n- [x] This is an improvement pr to move all the avc banner logic into a\r\nreusable kibana package (security solution and fleet integrations)\r\n- [x] Compresses the svg used in the banner's background \r\n- [x] Fixes a bug where the blog link didn't previously open in a new\r\ntab\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"14498a02214fbd312ad79497783b15ac7deb3b2b"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
Summary