Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package #188359

Merged
merged 18 commits into from
Jul 18, 2024

Conversation

parkiino
Copy link
Contributor

@parkiino parkiino commented Jul 15, 2024

Summary

  • This is an improvement pr to move all the avc banner logic into a reusable kibana package (security solution and fleet integrations)
  • Compresses the svg used in the banner's background
  • Fixes a bug where the blog link didn't previously open in a new tab

@parkiino parkiino added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v8.15.0 labels Jul 15, 2024
@parkiino parkiino requested review from a team as code owners July 15, 2024 19:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@parkiino parkiino requested a review from ashokaditya July 15, 2024 19:11
@parkiino parkiino removed the request for review from ashokaditya July 17, 2024 14:47
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet code LGTM

Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! nice work on extracting the banner! 🚀

@parkiino parkiino enabled auto-merge (squash) July 18, 2024 14:58
@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

@parkiino parkiino merged commit 14498a0 into elastic:main Jul 18, 2024
41 of 43 checks passed
@parkiino parkiino deleted the task/avc-banner-package branch July 18, 2024 23:37
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 188359

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@parkiino
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

parkiino added a commit to parkiino/kibana that referenced this pull request Jul 23, 2024
…kbn package (elastic#188359)

- [x] This is an improvement pr to move all the avc banner logic into a
reusable kibana package (security solution and fleet integrations)
- [x] Compresses the svg used in the banner's  background
- [x] Fixes a bug where the blog link didn't previously open in a new
tab

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 14498a0)
parkiino added a commit that referenced this pull request Jul 23, 2024
…into a kbn package (#188359) (#188892)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Security Solution][Admin][AVC Banner] AVC banner logic moved into a
kbn package (#188359)](#188359)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Candace
Park","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-18T23:24:28Z","message":"[Security
Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package
(#188359)\n\n## Summary\r\n\r\n- [x] This is an improvement pr to move
all the avc banner logic into a\r\nreusable kibana package (security
solution and fleet integrations)\r\n- [x] Compresses the svg used in the
banner's background \r\n- [x] Fixes a bug where the blog link didn't
previously open in a new\r\ntab\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"14498a02214fbd312ad79497783b15ac7deb3b2b","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Defend
Workflows","auto-backport","v8.15.0"],"number":188359,"url":"https://github.com/elastic/kibana/pull/188359","mergeCommit":{"message":"[Security
Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package
(#188359)\n\n## Summary\r\n\r\n- [x] This is an improvement pr to move
all the avc banner logic into a\r\nreusable kibana package (security
solution and fleet integrations)\r\n- [x] Compresses the svg used in the
banner's background \r\n- [x] Fixes a bug where the blog link didn't
previously open in a new\r\ntab\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"14498a02214fbd312ad79497783b15ac7deb3b2b"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team:Fleet Team label for Observability Data Collection Fleet team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants