This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fixes logging of target names with dashes #7281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in tracing-core which resulted in not supporting dashes in target names. This was fixed upstream. Besides that a test was added to ensure that we don't break this again.
bkchr
added
A0-please_review
andresilva
reviewed
Oct 8, 2020
| const EXPECTED_LOG_MESSAGE: &'static str = "yeah logging works as expected"; | ||
|
|
||
| #[test] | ||
| fn dash_in_target_name_works() { |
andresilva
approved these changes
Oct 8, 2020
| @@ -371,4 +372,33 @@ mod tests { | |||
| assert!(test_filter("telemetry", Level::TRACE)); | |||
There was a problem hiding this comment.
Maybe we can also add an example with dashes to this test 🤷
|
bot merge |
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
tomaka
approved these changes
Oct 8, 2020
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Oct 9, 2020
…up-updates * master: Async keystore + Authority-Discovery async/await (#7000) Fixes logging of target names with dashes (#7281) seal: Add automated weights for contract API calls (#7017) add ss58 id for nodle (#7279) Refactor CurrencyToVote (#6896) bump-allocator: document & poison (#7277) Reset flaming fir network (#7274) reschedule (#6860) Drop system cache for trie benchmarks (#7242) client: improve log formatting (#7272) Rework `InspectState` (#7271) SystemOrigin trait (#7226) Update ss58 registry for Dock network (#7263) .maintain/monitoring: Add alert when continuous task ends (#7250) Rename `TRANSACTION_VERSION` to `EXTRINSIC_VERSION` (#7258) Split block announce processing into two parts (#6958) Fix offchain election to respect the weight (#7215)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in tracing-core which resulted in not supporting dashes
in target names. This was fixed upstream. Besides that a test was added
to ensure that we don't break this again.
Fixes: #7251