This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
add ss58 id for nodle #7279
Merged
add ss58 id for nodle #7279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ETeissonniere it looks like you have not signed our contributor license aggreement yet. Please visit this link to sign our agreement. This pull request cannot be merged until the agrement is signed. |
|
@ETeissonniere, Your signature has been received. |
|
Please update the ss58registry.json file as well. Ty. |
|
Done! :) |
bkchr
approved these changes
Oct 8, 2020
|
@ETeissonniere can you please merge master. TY |
ETeissonniere
force-pushed
the
eliott/nodle-ss58
branch
from
2643b37 to
0e4388f
Compare
|
bot merge |
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
bkchr
added
A2-insubstantial
ordian
added a commit
that referenced
this pull request
Oct 9, 2020
…up-updates * master: Async keystore + Authority-Discovery async/await (#7000) Fixes logging of target names with dashes (#7281) seal: Add automated weights for contract API calls (#7017) add ss58 id for nodle (#7279) Refactor CurrencyToVote (#6896) bump-allocator: document & poison (#7277) Reset flaming fir network (#7274) reschedule (#6860) Drop system cache for trie benchmarks (#7242) client: improve log formatting (#7272) Rework `InspectState` (#7271) SystemOrigin trait (#7226) Update ss58 registry for Dock network (#7263) .maintain/monitoring: Add alert when continuous task ends (#7250) Rename `TRANSACTION_VERSION` to `EXTRINSIC_VERSION` (#7258) Split block announce processing into two parts (#6958) Fix offchain election to respect the weight (#7215)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the list of reserved SS58 IDs to include one for Nodle (37, we will keep 42 for Arcadia, our tesnet).
We'd then modify our node to include the reserved ID once this PR is merged.
✄ -----------------------------------------------------------------------------
Thank you for your Pull Request!
Before you submitting, please check that:
A*for PR status (one required)B*for changelog (one required)C*for release notes (exactly one required)D*for various implications/requirementsFixes #228orRelated #1337.Refer to the contributing guide for details.
After you've read this notice feel free to remove it.
Thank you!
✄ -----------------------------------------------------------------------------