This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove HashMap<EngineId, ...> from consensus-gossip #5553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
approved these changes
Apr 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #5265
Considering that each instance of
GossipEngineconcerns one engine ID, I cleaned this up and removed theHashMaps in favor of non-HashMaps.The validator is no longer registered after initialization, but must be passed to
new.The reputation penalty for using an unknown engine ID has been removed, since this path can no longer be reached anyway, and we handle that situation in
sc_networkdirectly.This is a first step towards cleaning up
sc-network-gossip.