This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Clean up sc_network_gossip #5265

Closed

tomaka opened this issue Mar 16, 2020 · 1 comment

Labels

Contributor

tomaka commented Mar 16, 2020

I initially started cleaning up as part of #5264, but realized that it was a lot of efforts.

Most notably, each instance of GossipEngine is specific to an engine_id, so there's no reason to use HashMaps anymore.

A good chunk of code can be simplified in there.

The text was updated successfully, but these errors were encountered:

tomaka added the I7-refactor label

tomaka mentioned this issue

Remove HashMap<EngineId, ...> from consensus-gossip #5553

Merged

Contributor Author

tomaka commented Jun 18, 2020

I'm going to close this issue, since it is vague anyway, as a duplicate of #6335

tomaka closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.