This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
deprecate try-runtime subcommand and direct users to standalone cli
#14731
+20
−627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
added
A2-insubstantial
ggwpez
approved these changes
Aug 8, 2023
kianenigma
approved these changes
Aug 10, 2023
kianenigma
approved these changes
Aug 10, 2023
…y-runtime-cli-deprecation-notice
Merged
1 task
liamaharon
added
A0-please_review
…ct.sh` execution scope
ggwpez
reviewed
Aug 11, 2023
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
…y-runtime-cli-deprecation-notice
liamaharon
added
B1-note_worthy
sergejparity
approved these changes
Aug 16, 2023
alvicsam
suggested changes
Aug 16, 2023
alvicsam
approved these changes
Aug 16, 2023
bkchr
reviewed
Aug 16, 2023
|
bot merge |
|
Error: Statuses failed for b550ff4 |
|
bot merge force |
paritytech-processbot
bot
deleted the
liam-try-runtime-cli-deprecation-notice
branch
Ank4n
pushed a commit
that referenced
this pull request
Aug 20, 2023
…#14731) * add deprecation notice * remove try-runtime-cli tests * update docs * add estimated removal date * deprecate and remove from node-cli and node-template * try fix build script * update comment * fix link * typo in build script * Move `try-runtime-cli` install step outside of `check_dependent_project.sh` execution scope * Update scripts/ci/gitlab/pipeline/build.yml Co-authored-by: Oliver Tale-Yazdi <[email protected]> * remove chain arg * build runtime with try-runtime feature * kick ci * kick ci * use main branch * specify sha in try-runtime-cli cargo install * kick ci * kick ci --------- Co-authored-by: Vladimir Istyufeev <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
10 tasks
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial #12975
The
try-runtimesubcommand has been migrated to a standalone CLI: paritytech/try-runtime-cli#6Removing the tests at the same time because to reduce load on the CI, they take a long time to run. Tests are migrated to the new repo.
polkadot companion: paritytech/polkadot#7599
TODO before merge
--branch liam-v0.1.0from CI command once v0.1.0: ready to replace existing substrate subcommand try-runtime-cli#6 is merged.