-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.1.0: ready to replace existing substrate subcommand #6
Conversation
I've also one general comment about substrate dependency: I clearly see a reason for depending on the it's out of the scope of this PR, but I would definitely spend some time on discussing how this tool should be versioned; maybe adding tags for |
SGTM, let's follow |
Standalone try-runtime-cli with feature parity with the existing substrate subcommand.
You can install the cli binary built from this branch to your path to play with by running
Once merged, we can deprecate & cease development of the
try-runtime
subcommand insubstrate
andpolkadot
and move development entirely to this repo.Partial paritytech/substrate#12975
master
on_runtime_upgrade
,execute_block
commands and internal logic to feature parity with substrateOffchainWorker
commandFollowChain
commandCreateSnapshot
commandmain
Runs testsI'm experiencing issues running tests in Github Actions. Devops team is probably going to completely re-do the CI/CD here here (seems they're already playing with something), so I'm not going to spend more time trying to fix this.A note about
fast-forward
I have intentionally left
fast-forward
out of this PR.It's not documented or really working in substrate currently, the idea of this PR is just to shift all stable features to this repo so we can continue development from here and deprecate try-runtime-cli in substrate.
I plan to work on
fast-forward
in a seperate PR, and only merge it when it is in a state where it is easy enough to use with any substrate based chain and well documented.TODO before merge
main
branch