Replace system config `Index` for `Nonce` #14290

juangirini · 2023-06-02T10:44:12Z

This PR renames frame_system::Config::Index to frame_system::Config::Nonce

This is a breaking change, therefore developers need to update the implementation of frame_system::Config for their Runtime

From something like this

impl frame_system::Config for Runtime {
  ...
  type Index = u64;

to

impl frame_system::Config for Runtime {
  ...
  type Nonce = u64;

Cumulus companion: paritytech/cumulus#2740
Polkadot companion: paritytech/polkadot#7374

ggwpez

So this is immediately breaking?
Maybe add a type-alias with a deprecation note for some transition time.

juangirini · 2023-06-02T10:55:26Z

So this is immediately breaking? Maybe add a type-alias with a deprecation note for some transition time.

@ggwpez That would be ideal, but how can you create a type alias in a trait?

ggwpez · 2023-06-02T15:07:13Z

Linking #14193 to have the breaking changes in System::Config in the same release.

juangirini · 2023-06-07T09:02:50Z

Linking #14193 to have the breaking changes in System::Config in the same release.

I will merge this PR when ~~#14193~~ #14437 is also ready so we introduce the breaking changes at once.

juangirini · 2023-07-14T06:56:39Z

bot merge

* replace Index by Nonce * replace Index by Nonce * replace Index by Nonce * replace Index by Nonce * replace Index by Nonce * wip * remove index in lieu of nonce * wip * remove accountnonce in lieu of nonce * add minor improvement * rebase and merge conflicts

* Removal of execution strategies (#14387) * Start * More work! * Moar * More changes * More fixes * More worrk * More fixes * More fixes to make it compile * Adds `NoOffchainStorage` * Pass the extensions * Small basti making small progress * Fix merge errors and remove `ExecutionContext` * Move registration of `ReadRuntimeVersionExt` to `ExecutionExtension` Instead of registering `ReadRuntimeVersionExt` in `sp-state-machine` it is moved to `ExecutionExtension` which provides the default extensions. * Fix compilation * Register the global extensions inside runtime api instance * Fixes * Fix `generate_initial_session_keys` by passing the keystore extension * Fix the grandpa tests * Fix more tests * Fix more tests * Don't set any heap pages if there isn't an override * Fix small fallout * FMT * Fix tests * More tests * Offchain worker custom extensions * More fixes * Make offchain tx pool creation reusable Introduces an `OffchainTransactionPoolFactory` for creating offchain transactions pools that can be registered in the runtime externalities context. This factory will be required for a later pr to make the creation of offchain transaction pools easier. * Fixes * Fixes * Set offchain transaction pool in BABE before using it in the runtime * Add the `offchain_tx_pool` to Grandpa as well * Fix the nodes * Print some error when using the old warnings * Fix merge issues * Fix compilation * Rename `babe_link` * Rename to `offchain_tx_pool_factory` * Cleanup * FMT * Fix benchmark name * Fix `try-runtime` * Remove `--execution` CLI args * Make clippy happy * Forward bls functions * Fix docs * Update UI tests * Update client/api/src/execution_extensions.rs Co-authored-by: Michal Kucharczyk <[email protected]> * Apply suggestions from code review Co-authored-by: Koute <[email protected]> * Update client/cli/src/params/import_params.rs Co-authored-by: Koute <[email protected]> * Update client/api/src/execution_extensions.rs Co-authored-by: Koute <[email protected]> * Pass the offchain storage to the MMR RPC * Update client/api/src/execution_extensions.rs Co-authored-by: Sebastian Kunert <[email protected]> * Review comments * Fixes --------- Co-authored-by: Michal Kucharczyk <[email protected]> Co-authored-by: Koute <[email protected]> Co-authored-by: Sebastian Kunert <[email protected]> * `GenesisBuild<T,I>` deprecated. `BuildGenesisConfig` added. (#14306) * frame::support: GenesisConfig types for Runtime enabled * frame::support: macro generating GenesisBuild::build for RuntimeGenesisConfig * frame: ambiguity BuildStorage vs GenesisBuild fixed * fix * RuntimeGenesisBuild added * Revert "frame: ambiguity BuildStorage vs GenesisBuild fixed" This reverts commit 6017dad. * Revert "fix" This reverts commit 477d7ad. * Revert "RuntimeGenesisBuild added" This reverts commit 3c131b6. * Revert "Revert "frame: ambiguity BuildStorage vs GenesisBuild fixed"" This reverts commit 2b1ecd4. * Revert "Revert "fix"" This reverts commit fd7fa62. * Code review suggestions * frame: BuildGenesisConfig added, BuildGenesis deprecated * frame: some pallets updated with BuildGenesisConfig * constuct_runtime: support for BuildGenesisConfig * frame::support: genesis_build macro supports BuildGenesisConfig * frame: BuildGenesisConfig added, BuildGenesis deprecated * Cargo.lock update * test-runtime: fixes * Revert "fix" This reverts commit 477d7ad. * Revert "frame: ambiguity BuildStorage vs GenesisBuild fixed" This reverts commit 6017dad. * self review * doc fixed * ui tests fixed * fmt * tests fixed * genesis_build macrto fixed for non-generic GenesisConfig * BuildGenesisConfig constraints added * warning fixed * some duplication removed * fmt * fix * doc tests fix * doc fix * cleanup: remove BuildModuleGenesisStorage * self review comments * fix * Update frame/treasury/src/tests.rs Co-authored-by: Sebastian Kunert <[email protected]> * Update frame/support/src/traits/hooks.rs Co-authored-by: Sebastian Kunert <[email protected]> * doc fix: GenesisBuild exposed * ".git/.scripts/commands/fmt/fmt.sh" * frame: more serde(skip) + cleanup * Update frame/support/src/traits/hooks.rs Co-authored-by: Davide Galassi <[email protected]> * frame: phantom fields moved to the end of structs * chain-spec: Default::default cleanup * test-runtime: phantom at the end * merge master fixes * fix * fix * fix * fix * fix (facepalm) * Update frame/support/procedural/src/pallet/expand/genesis_build.rs Co-authored-by: Bastian Köcher <[email protected]> * fmt * fix * fix --------- Co-authored-by: parity-processbot <> Co-authored-by: Sebastian Kunert <[email protected]> Co-authored-by: Davide Galassi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> * Moves `Block` to `frame_system` instead of `construct_runtime` and removes `Header` and `BlockNumber` (#14437) * Initial setup * Adds node block * Uses UncheckedExtrinsic and removes Where section * Updates frame_system to use Block * Adds deprecation warning * Fixes pallet-timestamp * Removes Header and BlockNumber * Addresses review comments * Addresses review comments * Adds comment about compiler bug * Removes where clause * Refactors code * Fixes errors in cargo check * Fixes errors in cargo check * Fixes warnings in cargo check * Formatting * Fixes construct_runtime tests * Uses import instead of full path for BlockNumber * Uses import instead of full path for Header * Formatting * Fixes construct_runtime tests * Fixes imports in benchmarks * Formatting * Fixes construct_runtime tests * Formatting * Minor updates * Fixes construct_runtime ui tests * Fixes construct_runtime ui tests with 1.70 * Fixes docs * Fixes docs * Adds u128 mock block type * Fixes split example * fixes for cumulus * ".git/.scripts/commands/fmt/fmt.sh" * Updates new tests * Fixes fully-qualified path in few places * Formatting * Update frame/examples/default-config/src/lib.rs Co-authored-by: Juan <[email protected]> * Update frame/support/procedural/src/construct_runtime/mod.rs Co-authored-by: Juan <[email protected]> * ".git/.scripts/commands/fmt/fmt.sh" * Addresses some review comments * Fixes build * ".git/.scripts/commands/fmt/fmt.sh" * Update frame/democracy/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <[email protected]> * Update frame/democracy/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <[email protected]> * Update frame/support/procedural/src/construct_runtime/mod.rs Co-authored-by: Oliver Tale-Yazdi <[email protected]> * Update frame/support/procedural/src/construct_runtime/mod.rs Co-authored-by: Oliver Tale-Yazdi <[email protected]> * Addresses review comments * Updates trait bounds * Minor fix * ".git/.scripts/commands/fmt/fmt.sh" * Removes unnecessary bound * ".git/.scripts/commands/fmt/fmt.sh" * Updates test * Fixes build * Adds a bound for header * ".git/.scripts/commands/fmt/fmt.sh" * Removes where block * Minor fix * Minor fix * Fixes tests * ".git/.scripts/commands/update-ui/update-ui.sh" 1.70 * Updates test * Update primitives/runtime/src/traits.rs Co-authored-by: Bastian Köcher <[email protected]> * Update primitives/runtime/src/traits.rs Co-authored-by: Bastian Köcher <[email protected]> * Updates doc * Updates doc --------- Co-authored-by: command-bot <> Co-authored-by: Juan <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> * Replace system config `Index` for `Nonce` (#14290) * replace Index by Nonce * replace Index by Nonce * replace Index by Nonce * replace Index by Nonce * replace Index by Nonce * wip * remove index in lieu of nonce * wip * remove accountnonce in lieu of nonce * add minor improvement * rebase and merge conflicts --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Michal Kucharczyk <[email protected]> Co-authored-by: Koute <[email protected]> Co-authored-by: Sebastian Kunert <[email protected]> Co-authored-by: Davide Galassi <[email protected]> Co-authored-by: gupnik <[email protected]> Co-authored-by: Juan <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>

* replace Index by Nonce * replace Index by Nonce * replace Index by Nonce * replace Index by Nonce * replace Index by Nonce * wip * remove index in lieu of nonce * wip * remove accountnonce in lieu of nonce * add minor improvement * rebase and merge conflicts

juangirini added 9 commits May 24, 2023 14:35

replace Index by Nonce

b42011f

replace Index by Nonce

04b7a39

replace Index by Nonce

1dd5e6a

replace Index by Nonce

4b93fc7

replace Index by Nonce

2becc48

wip

8488107

remove index in lieu of nonce

29c5699

wip

f8952d9

remove accountnonce in lieu of nonce

10087f1

juangirini self-assigned this Jun 2, 2023

juangirini requested review from a team June 2, 2023 10:44

juangirini requested review from athei, acatangiu, andresilva and jsidorenko as code owners June 2, 2023 10:44

juangirini requested a review from a team June 2, 2023 10:44

juangirini requested a review from cheme as a code owner June 2, 2023 10:44

bkchr approved these changes Jun 2, 2023

View reviewed changes

merge master and fix conflicts

ffb03ce

ggwpez reviewed Jun 2, 2023

View reviewed changes

add minor improvement

a52753b

AurevoirXavier mentioned this pull request Aug 24, 2023

[Deprecation] Index vs Nonce paritytech/polkadot-sdk#243

Closed

2 tasks

AurevoirXavier approved these changes Jun 7, 2023

View reviewed changes

shawntabrizi approved these changes Jun 7, 2023

View reviewed changes

sam0x17 approved these changes Jun 8, 2023

View reviewed changes

juangirini mentioned this pull request Jun 15, 2023

Moves Block, NodeBlock and UncheckedExtrinsic to frame_system, instead of construct_runtime #14193

Closed

juangirini removed the A0-please_review Pull request needs code review. label Jun 15, 2023

This was referenced Jun 15, 2023

Replace Index for Nonce paritytech/cumulus#2740

Merged

Replace Index for Nonce paritytech/polkadot#7374

Merged

juangirini added 3 commits July 13, 2023 14:07

rebase and fix conflicts

5bc2eb9

rebase and merge conflicts

7cb875f

rebase and merge conflicts

f3b7522

paritytech-processbot bot merged commit c446786 into master Jul 14, 2023

paritytech-processbot bot deleted the jg/12649-deprecation-index-vs-nonce branch July 14, 2023 06:56

EgorPopelyaev mentioned this pull request Jul 18, 2023

Ep backport missing cumulus companions #14594

Merged

brenzi mentioned this pull request Jul 22, 2023

upgrade to polkadot-v1.0.0 encointer/pallets#332

Merged

juangirini mentioned this pull request Aug 9, 2023

Update examples and tutorials for deprecated Index polkadot-developers/substrate-docs#2035

Closed

crystalin mentioned this pull request Oct 20, 2023

Update substrate/polkadot/cumulus from v0.9.43 to v1.1.0 moonbeam-foundation/moonbeam#2535

Closed

JesseAbram mentioned this pull request Oct 26, 2023

Update substrate and subxt entropyxyz/entropy-core#435

Merged

ukint-vs mentioned this pull request Dec 19, 2023

feat: update substrate to v1.0.0 gear-tech/gear#3608

Merged

dnjscksdn98 mentioned this pull request Jan 12, 2024

NODE-65, deps: polkadot sdk migration bifrost-platform/bifrost-node#36

Merged

13 tasks

brenzi mentioned this pull request Jan 21, 2024

Polkadot v1.0.0 upgrade integritee-network/pallets#245

Merged

ashutoshvarma mentioned this pull request Feb 27, 2024

feat: update to polkadot v1.1.0 release AstarNetwork/Astar#1182

Merged

13 tasks

surangap mentioned this pull request May 29, 2024

Upgrade Substrate to v1.0.0 futureversecom/trn-seed#821

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace system config `Index` for `Nonce` #14290

Replace system config `Index` for `Nonce` #14290

juangirini commented Jun 2, 2023 •

edited

Loading

ggwpez left a comment •

edited

Loading

juangirini commented Jun 2, 2023 •

edited

Loading

ggwpez commented Jun 2, 2023

juangirini commented Jun 7, 2023 •

edited

Loading

juangirini commented Jul 14, 2023

Replace system config Index for Nonce #14290

Replace system config Index for Nonce #14290

Conversation

juangirini commented Jun 2, 2023 • edited Loading

ggwpez left a comment • edited Loading

Choose a reason for hiding this comment

juangirini commented Jun 2, 2023 • edited Loading

ggwpez commented Jun 2, 2023

juangirini commented Jun 7, 2023 • edited Loading

juangirini commented Jul 14, 2023

Replace system config `Index` for `Nonce` #14290

Replace system config `Index` for `Nonce` #14290

juangirini commented Jun 2, 2023 •

edited

Loading

ggwpez left a comment •

edited

Loading

juangirini commented Jun 2, 2023 •

edited

Loading

juangirini commented Jun 7, 2023 •

edited

Loading