-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to polkadot-v1.0.0 #332
Conversation
still getting error logs during tests, deemed insubstantial: |
hmm, this may be relevant too, even if older: paritytech/substrate#14261 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good in general, some minor questions, and I might have spotted the missing serialize implementation error.
I made an issue of this. This is suspicious, in the worst case, it could mean that we forget to increment a provider count when we should, and as a result we might kill an account, which should not be killed yet. #333 |
Hmm, this probably means that we need to enable the Unfortunately, I just tried it and it seems to introduce an std-leackage.... |
I should have checked it more thoroughly, it does fix the runtime build. It is just the node, which also needs some fixes then. However, if the node requires this flag now in any case, it is better to enable encointer-primitive's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
noteworthy causes for change:
T::BlockNumber
MovesBlock
toframe_system
instead ofconstruct_runtime
and removesHeader
andBlockNumber
paritytech/substrate#14437GenesisBuild<T,I>
deprecated.BuildGenesisConfig
added. paritytech/substrate#14306Block
toframe_system
instead ofconstruct_runtime
and removesHeader
andBlockNumber
paritytech/substrate#14437Index
forNonce
paritytech/substrate#14290once merged, reset branch polkadot-v1.0.0