Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to polkadot-v1.0.0 #332

Merged
merged 10 commits into from
Jul 30, 2023
Merged

upgrade to polkadot-v1.0.0 #332

merged 10 commits into from
Jul 30, 2023

Conversation

@brenzi
Copy link
Member Author

brenzi commented Jul 22, 2023

still getting error logs during tests, deemed insubstantial:
Jul 22 16:34:17.299 ERROR runtime::system: Logic error: Account already dead when reducing provider

@brenzi brenzi marked this pull request as ready for review July 22, 2023 14:37
@brenzi
Copy link
Member Author

brenzi commented Jul 22, 2023

hmm, this may be relevant too, even if older: paritytech/substrate#14261

Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general, some minor questions, and I might have spotted the missing serialize implementation error.

ceremonies/src/lib.rs Show resolved Hide resolved
communities/src/lib.rs Show resolved Hide resolved
faucet/src/lib.rs Show resolved Hide resolved
reputation-commitments/Cargo.toml Show resolved Hide resolved
rust-toolchain.toml Show resolved Hide resolved
balances/src/lib.rs Show resolved Hide resolved
@clangenb
Copy link
Member

clangenb commented Jul 23, 2023

Jul 22 16:34:17.299 ERROR runtime::system: Logic error: Account already dead when reducing provider

I made an issue of this. This is suspicious, in the worst case, it could mean that we forget to increment a provider count when we should, and as a result we might kill an account, which should not be killed yet. #333

@clangenb
Copy link
Member

clangenb commented Jul 23, 2023

hmm, this may be relevant too, even if older: paritytech/substrate#14261

Hmm, this probably means that we need to enable the serde_derive feature here: https://github.com/encointer/encointer-node/blob/0e4b92736783483ec35d21ba09fc0d20fdad9346/runtime/Cargo.toml#L21, which we currently only do in std.

Unfortunately, I just tried it and it seems to introduce an std-leackage....

@clangenb
Copy link
Member

hmm, this may be relevant too, even if older: paritytech/substrate#14261

Hmm, this probably means that we need to enable the serde_derive feature here: https://github.com/encointer/encointer-node/blob/0e4b92736783483ec35d21ba09fc0d20fdad9346/runtime/Cargo.toml#L21, which we currently only do in std.

Unfortunately, I just tried it and it seems to introduce an std-leackage....

I should have checked it more thoroughly, it does fix the runtime build. It is just the node, which also needs some fixes then. However, if the node requires this flag now in any case, it is better to enable encointer-primitive's serde_derive flag from within the pallets, such that the node does not need to care about it.

Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brenzi brenzi merged commit d2f0acd into master Jul 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants