This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[contracts] Forbid calling back to contracts after switching to runtime #13443
+287
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agryaznov
added
A0-please_review
agryaznov
changed the title
athei
added
T4-smart_contracts
athei
reviewed
Feb 23, 2023
athei
removed
the
T4-smart_contracts
xermicus
reviewed
Feb 23, 2023
|
@athei your feedback is addressed, thanks! |
xermicus
reviewed
Feb 27, 2023
athei
reviewed
Mar 3, 2023
Co-authored-by: Alexander Theißen <[email protected]>
athei
approved these changes
Mar 3, 2023
xermicus
approved these changes
Mar 4, 2023
|
bot merge |
jakoblell
added
D1-audited 👍
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
…me (paritytech#13443) * save: compiles and tests pass * save: added global * done + test * cleanup * changelog update * cleanup * address feedback, step 1 * address feedback, step 2 * address feedback, step 3 * returned updated gas_estimation_call_runtime test * clippy fix * address feedback, step 4 * address feedback, step 5 * move data from context to inputs * docs fix * Apply suggestions from code review Co-authored-by: Alexander Theißen <[email protected]> * address feedback, step 6 --------- Co-authored-by: Alexander Theißen <[email protected]>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…me (paritytech#13443) * save: compiles and tests pass * save: added global * done + test * cleanup * changelog update * cleanup * address feedback, step 1 * address feedback, step 2 * address feedback, step 3 * returned updated gas_estimation_call_runtime test * clippy fix * address feedback, step 4 * address feedback, step 5 * move data from context to inputs * docs fix * Apply suggestions from code review Co-authored-by: Alexander Theißen <[email protected]> * address feedback, step 6 --------- Co-authored-by: Alexander Theißen <[email protected]>
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pallet Contracts provides ways to call runtime from a contract, i.e.
call_runtimeand chain extensions.With this PR, we guard contracts from back-forth invocation after switching once from contracts engine to runtime, to avoid possible re-entrancy flaws.